feat: a diver's portrait - #28
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification adds
diver.portrait_file, a Stored File, in divejson/divejson#28. This pinsSPEC_REFto its merged commit and vendors the three trees. The validator now claims the portrait's uuid in the document's single identifier space, so a portrait that shares a uuid with any other record is refused under §5.3. UDDF carries no portrait in either direction. The writer reports the member throughunmappedwhen it writes an owner, and through the guard's own note when it writes none. The self round trip'sLOSTset gainsdiver/portrait_file.Verified with
pytest(1085 passed),divejson conform fixtures --strict, and.github/scripts/spec_pin.pyagainst the specification checkout.🤖 Generated with Claude Code