Conversation
There was a problem hiding this comment.
Pull request overview
This draft PR scaffolds the initial PHP implementation of divengine/runner, including a baseline runner core with explicit path-based importing, plus CI/static analysis, tests, benchmarks, and documentation.
Changes:
- Introduces
src/runner.phpwith the runner core, importer, pause/jump token mechanics, logging, and context helpers. - Adds PHPUnit + PHPStan configuration and GitHub Actions workflows to run them on PRs.
- Adds initial unit tests, phpbench benchmarks, and basic docs/release notes.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/runner.php |
New runner core implementation (run/importer/helpers/logging/flowLoop). |
tests/bootstrap.php |
Test bootstrap loading Composer autoload or direct runner include. |
tests/RunnerTest.php |
PHPUnit coverage for run/importer/pause-jump/helpers/serialization. |
bench/runnerBench.php |
Baseline phpbench subjects for callable flow, importer flow, and flowLoop. |
composer.json |
Composer package metadata + dev tooling deps + scripts (test/bench/phpstan). |
phpunit.xml |
PHPUnit configuration and source include. |
phpstan.neon |
PHPStan configuration (incl. baseline). |
phpstan-baseline.neon |
Empty PHPStan baseline placeholder. |
phpbench.json |
phpbench runner config pointing at bench and test bootstrap. |
.github/workflows/tests.yml |
CI job running PHPUnit on PRs. |
.github/workflows/phpstan.yml |
CI job running PHPStan on PRs. |
.github/workflows/release.yml |
Release automation driven by composer.json version + release notes file. |
README.md |
Package README with install/usage/docs/bench info. |
docs/README.md |
Expanded documentation on context keys and injected helpers. |
releases/README.md |
Release notes process documentation. |
releases/v0.1.0.md |
Initial release notes for v0.1.0. |
scripts/README.md |
Placeholder for automation scripts. |
.gitignore |
Ignores vendor/build/cache/editor files. |
.gitattributes |
Marks internal/dev folders as export-ignore. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This draft PR introduces the first stable baseline for
divengine/runnerin PHP and will remain open while more changes are added.Included changes
src/runner.phpusing a shared context array by reference.returna callable (require), with optional.phpextension.RuntimeExceptionmessages.tests/RunnerTest.php.phpbench.src/runner.php.Related issues
Local validation
vendor/bin/phpunit-> OKcomposer bench-> OKphp -l src/runner.php-> OKStatus