Fix stuck landscape orientation in depth profile fullscreen (PRO-65)

[shaheinm]

Summary

• DepthProfileFullscreenView had the identical stuck-orientation bug fixed for the replay chart in Add replay chart v2 with ceiling/GF overlays and fullscreen (PRO-51) #163: it reset AppDelegate.orientationLock on dismiss but never called setNeedsUpdateOfSupportedInterfaceOrientations(), which UIKit requires to re-query supported orientations — so the phone stayed locked in landscape after closing the fullscreen chart.
• Extracts a shared landscapeFullscreen(onSwipeDismiss:) view modifier (Helpers/LandscapeFullscreenModifier.swift) and adopts it in both DepthProfileFullscreenView and ReplayChartFullscreenView, removing the duplicated orientation-lock pattern.
• The depth profile fullscreen also gains portrait snap-back on close and downward swipe-to-dismiss, for parity with the replay chart.

Closes PRO-65. Fixes #164.

Test plan

• Open a dive → fullscreen depth profile → close via X → returns to portrait, rotation works
• Fullscreen depth profile → swipe down → dismisses
• Replay fullscreen chart still locks landscape, swipe-dismisses (pausing animation), and restores portrait
• macOS sheet presentation unaffected (modifier is a no-op off iOS)

Validation

• SwiftLint strict: clean
• macOS build: green
• iOS device build: green
• View-layer change only — covered by manual QA per testing standards

Made with Cursor

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[shaheinm]

Second-opinion review (gpt-5.3-codex) — no blockers → addressed in latest commit

Should-fixes (both addressed):

• connectedScenes.first could target the wrong scene under iPad multitasking / Stage Manager. → Now prefers the foreground-active window scene, falling back to the first.
• Vertical-only swipe threshold could false-trigger on diagonal chart scrubs. → Added dominant-axis check (height > abs(width)).

Nit (not addressed): requestGeometryUpdate errors are ignored; could log in debug for diagnosability. Left as-is — matches existing codebase style.

Confirmed correct by review: orientation lock/restore + setNeedsUpdateOfSupportedInterfaceOrientations() fix, modifier ordering, @Environment(\.dismiss) in the modifier, macOS compile gating (no iOS symbol leaks).

SwiftLint clean, macOS + iOS device builds green.