Add a holdout-safe Fit experience index - #18
Open
divo12 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/ofw/benchmarking.py">
<violation number="1" location="src/ofw/benchmarking.py:82">
P2: When a repository already contains a baseline or Fit manifest from before this change, cached reads reject its attempts because `source_case_id` is missing, and legacy baseline verification reports semantic drift after the field is added to `_semantic`. Add backward-compatible deserialization and preserve the legacy digest for old artifacts, or explicitly version and migrate/invalidate these persisted results.</violation>
</file>
You're on the cubic free plan with 18 free PR reviews remaining this month. Upgrade for unlimited reviews.
Re-trigger cubic
| @dataclass(frozen=True, slots=True) | ||
| class CaseAttempt: | ||
| case_id: str | ||
| source_case_id: str |
There was a problem hiding this comment.
P2: When a repository already contains a baseline or Fit manifest from before this change, cached reads reject its attempts because source_case_id is missing, and legacy baseline verification reports semantic drift after the field is added to _semantic. Add backward-compatible deserialization and preserve the legacy digest for old artifacts, or explicitly version and migrate/invalidate these persisted results.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/ofw/benchmarking.py, line 82:
<comment>When a repository already contains a baseline or Fit manifest from before this change, cached reads reject its attempts because `source_case_id` is missing, and legacy baseline verification reports semantic drift after the field is added to `_semantic`. Add backward-compatible deserialization and preserve the legacy digest for old artifacts, or explicitly version and migrate/invalidate these persisted results.</comment>
<file context>
@@ -79,6 +79,7 @@ def digest(self) -> Sha256Digest:
@dataclass(frozen=True, slots=True)
class CaseAttempt:
case_id: str
+ source_case_id: str
partition: ExportPartition
critical: bool
</file context>
…-index # Conflicts: # src/ofw/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification