feat: add typed experiment ledger - #32
Open
divo12 wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
1 issue found across 15 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="plugins/openflywheel/.codex-plugin/plugin.json">
<violation number="1" location="plugins/openflywheel/.codex-plugin/plugin.json:14">
P1: Installed plugin instances still launch an MCP commit that does not expose `record_experiment`, so this new description advertises an unavailable feature. Update `.mcp.json` to pin a release containing the ledger tool.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
divo12
force-pushed
the
ao/openflywheel-6/experiment-ledger
branch
from
September 2, 2026 10:28
bb96a6a to
12244ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
record_experimentMCP tool.workspace/experiments/while reusing the hardened local artifact publisherVerification
uv run ruff format --checkon all changed Python filesuv run ruff check src tests plugins/openflywheel/scripts/mcp_server.pyuv run mypy src tests plugins/openflywheel/scripts/mcp_server.pyuv run pytest --cov=ofw --cov-report=term-missing --cov-fail-under=90 -q— 187 passed, 2 skipped, 95.40% coverageuvx --from radon radon cc -s -a src tests plugins/openflywheel/scripts/mcp_server.py— average A; changed ledger functions at 5 or belowScope and follow-ups
PROGRAM.md; the ledger instruction applies to newly prepared workspacesSummary by cubic
Previously, terminal experiment decisions were not persisted. This adds a typed, immutable, idempotent ledger under
.workspace/experiments/and requires newly prepared agent programs to callrecord_experiment; existing prepared workspaces keep their generatedPROGRAM.md.Changes
Written for commit 12244ef. Summary will update on new commits.