Skip to content

Add Test Coverage#2

Merged
djburkhart merged 4 commits into
mainfrom
refactor/coverage-work
May 18, 2026
Merged

Add Test Coverage#2
djburkhart merged 4 commits into
mainfrom
refactor/coverage-work

Conversation

@djburkhart
Copy link
Copy Markdown
Owner

Adds more test coverage.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds test coverage across CLI, config parsing/validation, GCP client wrappers, and the binary entrypoint, with small test seams added for command execution and GCP client construction.

Changes:

  • Added injectable factory variables for CLI execution and GCP client constructors.
  • Expanded unit tests for CLI commands, config loader/parser branches, Cloud Build/Run clients, and main.
  • Updated the changelog for v0.2.3 test coverage changes.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/gcp/run.go Adds a Cloud Run service-client factory seam.
internal/gcp/run_test.go Adds constructor and close-path tests for RunClient.
internal/gcp/cloudbuild.go Adds a Cloud Build API factory seam.
internal/gcp/cloudbuild_test.go Adds constructor, build status, wait/no-wait, and metadata tests.
internal/config/loader_test.go Expands external config validation and parsing error coverage.
internal/config/loader_internal_test.go Expands internal parser and merge helper coverage.
internal/cli/root.go Adds injectable root execution, stderr, and exit seams.
internal/cli/cli_test.go Expands CLI command success/error/write-path coverage.
cmd/kdlctl/main.go Adds an injectable CLI execution seam for testing main.
cmd/kdlctl/main_test.go Adds main entrypoint coverage.
CHANGELOG.md Documents the v0.2.3 test coverage update.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/cli/cli_test.go Outdated
Comment thread internal/cli/cli_test.go Outdated
djburkhart and others added 3 commits May 18, 2026 08:58
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Owner Author

@djburkhart djburkhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my approval.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

@djburkhart djburkhart merged commit 68440d8 into main May 18, 2026
5 checks passed
@djburkhart djburkhart deleted the refactor/coverage-work branch May 18, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants