fix(parser): allow trailing whitespace before closing parenthesis #190#191
Merged
fix(parser): allow trailing whitespace before closing parenthesis #190#191
Conversation
…#190 Some real-world IMAP servers include extra whitespace before the closing parenthesis. This change makes the parser more robust by allowing zero or more spaces.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 76.29% 76.35% +0.06%
==========================================
Files 21 21
Lines 2826 2829 +3
==========================================
+ Hits 2156 2160 +4
+ Misses 670 669 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djc
approved these changes
Apr 20, 2026
| delimited( | ||
| char('('), | ||
| separated_list1(char(' '), f), | ||
| // Targeted lenience: Some real-world IMAP servers |
Owner
There was a problem hiding this comment.
Can you be more concrete about which server? If feasible, did you file an issue against it?
Author
There was a problem hiding this comment.
No, this comes from feedback from a user.
If feasible, did you file an issue against it?
Owner
There was a problem hiding this comment.
Apparently this might be some (older?) version of Cyrus IMAP.
Owner
|
If you want a release for this, can you submit a PR with a version bump? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some real-world IMAP servers include extra whitespace before the closing parenthesis. This change makes the parser more robust by allowing zero or more spaces.