Skip to content

chore[API]: create session factory to avoid memory leaks #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djsilva99 merged 3 commits into from
Mar 9, 2026
Merged

chore[API]: create session factory to avoid memory leaks #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bff1ff9
chore[API]: create session factory to reduce memory usage
djsilva99 Mar 9, 2026
6cbe428
test[API]: update tests for session factory
djsilva99 Mar 9, 2026
4d0e7e7
chore[API]: update job_processors to remove unused memory
djsilva99 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 72 additions & 49 deletions apps/api/src/adapters/entrypoints/v1/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import secrets
from uuid import UUID

from fastapi import APIRouter, Depends, HTTPException, Query, Response, status
from fastapi import APIRouter, Depends, HTTPException, Query, Request, Response, status
from fastapi.responses import StreamingResponse
from fastapi.security import OAuth2PasswordBearer
from src.adapters.entrypoints.v1.models.authentication import LoginRequest
Expand Down Expand Up @@ -40,22 +40,10 @@
map_source_to_create_source_response,
)
from src.adapters.entrypoints.v1.models.welcome import WelcomeResponse
from src.configs.dependencies.services import (
get_feed_service,
get_filter_service,
get_job_service,
get_picker_service,
get_source_service,
)
from src.configs.settings import Settings
from src.domain.models.feed import FeedItemRequest, FeedRequest, UpdateFeedRequest
from src.domain.models.picker import PickerRequest
from src.domain.models.source import SourceRequest
from src.domain.services.feed_service import FeedService
from src.domain.services.filter_service import FilterService
from src.domain.services.job_service import JobService
from src.domain.services.picker_service import PickerService
from src.domain.services.source_service import SourceService

settings: Settings = Settings()

Expand Down Expand Up @@ -130,9 +118,11 @@ def login(data: LoginRequest):
}
)
def list_sources(
request: Request,
_: str = Depends(authenticate), # noqa: B008
source_service: SourceService = Depends(get_source_service) # noqa: B008
) -> GetAllSourcesResponse:
source_service = request.app.state.job_service.source_service

source_list = source_service.get_all_sources()
return GetAllSourcesResponse(
sources=map_source_list_to_get_all_sources_response(source_list=source_list)
Expand Down Expand Up @@ -161,9 +151,11 @@ def list_sources(
)
def create_source(
create_source_request: ExternalSourceRequest,
request: Request,
_: str = Depends(authenticate), # noqa: B008
source_service: SourceService = Depends(get_source_service) # noqa: B008
) -> SourceResponse:
source_service = request.app.state.job_service.source_service

source_request = SourceRequest(name=create_source_request.name, url=create_source_request.url)
created_source = source_service.create_source(source_request)
return map_source_to_create_source_response(created_source)
Expand Down Expand Up @@ -192,9 +184,11 @@ def create_source(
)
def get_source(
source_external_id: UUID,
request: Request,
_: str = Depends(authenticate), # noqa: B008
source_service: SourceService = Depends(get_source_service) # noqa: B008
) -> SourceResponse:
source_service = request.app.state.job_service.source_service

source = source_service.get_source_by_external_id(
source_external_id
)
Expand Down Expand Up @@ -227,9 +221,11 @@ def get_source(
def update_source(
source_external_id: UUID,
update_source_request: ExternalSourceRequest,
request: Request,
_: str = Depends(authenticate), # noqa: B008
source_service: SourceService = Depends(get_source_service), # noqa: B008
) -> SourceResponse:
source_service = request.app.state.job_service.source_service

source_request = SourceRequest(
name=update_source_request.name,
url=update_source_request.url
Expand All @@ -253,12 +249,14 @@ def update_source(
)
def delete_source(
source_external_id: UUID,
request: Request,
_: str = Depends(authenticate), # noqa: B008
source_service: SourceService = Depends(get_source_service), # noqa: B008
filter_service: FilterService = Depends(get_filter_service), # noqa: B008
picker_service: PickerService = Depends(get_picker_service), # noqa: B008
job_service: JobService = Depends(get_job_service), # noqa: B008
):
source_service = request.app.state.job_service.source_service
filter_service = request.app.state.job_service.filter_service
picker_service = request.app.state.job_service.picker_service
job_service = request.app.state.job_service

source = source_service.get_source_by_external_id(
external_id=source_external_id
)
Expand Down Expand Up @@ -296,9 +294,11 @@ def delete_source(
}
)
def list_feeds(
request: Request,
_: str = Depends(authenticate), # noqa: B008
feed_service: FeedService = Depends(get_feed_service) # noqa: B008
) -> ListFeedsResponse:
feed_service = request.app.state.job_service.feed_service

detailed_feeds_list = feed_service.get_detailed_feeds()

return map_detailed_feeds_list_to_list_feeds_response(detailed_feeds_list)
Expand Down Expand Up @@ -326,9 +326,11 @@ def list_feeds(
)
def create_feed(
create_feed_request: CreateFeedRequest,
request: Request,
_: str = Depends(authenticate), # noqa: B008
feed_service: FeedService = Depends(get_feed_service) # noqa: B008
) -> FeedResponse:
feed_service = request.app.state.job_service.feed_service

feed_request = FeedRequest(name=create_feed_request.name)
created_feed = feed_service.create_feed(feed_request)
return map_feed_to_feed_response(created_feed)
Expand Down Expand Up @@ -358,9 +360,11 @@ def create_feed(
def update_feed(
feed_external_id: UUID,
update_feed_request: ExternalUpdateFeedRequest,
request: Request,
_: str = Depends(authenticate), # noqa: B008
feed_service: FeedService = Depends(get_feed_service) # noqa: B008
) -> FeedResponse:
feed_service = request.app.state.job_service.feed_service

update_feed_request = UpdateFeedRequest(
name=update_feed_request.name
)
Expand All @@ -383,12 +387,14 @@ def update_feed(
)
def delete_feed(
feed_external_id: UUID,
request: Request,
_: str = Depends(authenticate), # noqa: B008
feed_service: FeedService = Depends(get_feed_service), # noqa: B008
filter_service: FilterService = Depends(get_filter_service), # noqa: B008
picker_service: PickerService = Depends(get_picker_service), # noqa: B008
job_service: JobService = Depends(get_job_service), # noqa: B008
):
feed_service = request.app.state.job_service.feed_service
filter_service = request.app.state.job_service.filter_service
picker_service = request.app.state.job_service.picker_service
job_service = request.app.state.job_service

feed = feed_service.get_feed_by_external_id(external_id=feed_external_id)
if not feed:
raise HTTPException(status_code=404, detail="Feed not found")
Expand Down Expand Up @@ -428,12 +434,14 @@ def delete_feed(
)
def get_feed_rss(
external_id: UUID,
feed_service: FeedService = Depends(get_feed_service) # noqa: B008
request: Request,
):
"""
Returns raw RSS XML for the requested feed.
The response content type is `application/rss+xml`.
"""
feed_service = request.app.state.job_service.feed_service

feeds_rss = feed_service.get_rss(external_id)
if feeds_rss:
return Response(
Expand Down Expand Up @@ -465,18 +473,20 @@ def get_feed_rss(
}
)
def get_feed(
request: Request,
external_id: UUID,
title: str | None = Query(None),
last_day: bool | None = Query(None),
rss_items: bool | None = Query(None),
feed_items_limit: int | None = Query(None, ge=1),
feed_items_offset: int | None= Query(None, ge=0),
_: str = Depends(authenticate), # noqa: B008
feed_service: FeedService = Depends(get_feed_service), # noqa: B008
filter_service: FilterService = Depends(get_filter_service), # noqa: B008
picker_service: PickerService = Depends(get_picker_service), # noqa: B008
source_service: SourceService = Depends(get_source_service), # noqa: B008
) -> FullCompleteFeed:
feed_service = request.app.state.job_service.feed_service
filter_service = request.app.state.job_service.filter_service
picker_service = request.app.state.job_service.picker_service
source_service = request.app.state.job_service.source_service

feed = feed_service.get_feed_by_external_id(external_id)
if not feed:
raise HTTPException(status_code=404, detail="Feed not found")
Expand Down Expand Up @@ -552,9 +562,11 @@ def get_feed(
def create_feed_item(
feed_external_id: UUID,
create_feed_item_request: CreateFeedItemRequest,
request: Request,
_: str = Depends(authenticate), # noqa: B008
feed_service: FeedService = Depends(get_feed_service), # noqa: B008
) -> CreateFeedItemResponse:
feed_service = request.app.state.job_service.feed_service

feed = feed_service.get_feed_by_external_id(feed_external_id)
if not feed:
raise HTTPException(status_code=400, detail="Feed not found")
Expand Down Expand Up @@ -600,9 +612,11 @@ def create_feed_item(
def get_feed_item(
feed_external_id: UUID,
feed_item_external_id: UUID,
request: Request,
_: str = Depends(authenticate), # noqa: B008
feed_service: FeedService = Depends(get_feed_service), # noqa: B008
) -> GetFeedItemResponse:
feed_service = request.app.state.job_service.feed_service

feed_item = feed_service.get_feed_item_by_external_id(feed_item_external_id)
if not feed_item:
raise HTTPException(status_code=400, detail="Feed item not found")
Expand All @@ -620,9 +634,11 @@ def get_feed_item(
def delete_feed_item(
feed_external_id: UUID,
feed_item_external_id: UUID,
request: Request,
_: str = Depends(authenticate), # noqa: B008
feed_service: FeedService = Depends(get_feed_service), # noqa: B008
):
feed_service = request.app.state.job_service.feed_service

feed_item = feed_service.get_feed_item_by_external_id(
feed_item_external_id=feed_item_external_id
)
Expand All @@ -649,9 +665,11 @@ def delete_feed_item(
def export_feed_items(
feed_external_id: UUID,
export_feed_items_request: ExportFeedItemsRequest,
request: Request,
_: str = Depends(authenticate), # noqa: B008
feed_service: FeedService = Depends(get_feed_service), # noqa: B008
):
feed_service = request.app.state.job_service.feed_service

buffer = feed_service.export_file(
feed_external_id,
export_feed_items_request.file_type,
Expand Down Expand Up @@ -692,13 +710,14 @@ def export_feed_items(
)
def add_picker(
create_full_picker_request: CreateFullPickerRequest,
request: Request,
_: str = Depends(authenticate), # noqa: B008
filter_service: FilterService = Depends(get_filter_service), # noqa: B008
picker_service: PickerService = Depends(get_picker_service), # noqa: B008
source_service: SourceService = Depends(get_source_service), # noqa: B008
feed_service: FeedService = Depends(get_feed_service), # noqa: B008
job_service: JobService = Depends(get_job_service), # noqa: B008
) -> FullPickerResponse:
feed_service = request.app.state.job_service.feed_service
filter_service = request.app.state.job_service.filter_service
picker_service = request.app.state.job_service.picker_service
source_service = request.app.state.job_service.source_service
job_service = request.app.state.job_service

feed_name = None
if create_full_picker_request.feed_name:
Expand Down Expand Up @@ -797,12 +816,14 @@ def add_picker(
)
def get_picker(
picker_external_id: UUID,
request: Request,
_: str = Depends(authenticate), # noqa: B008
filter_service: FilterService = Depends(get_filter_service), # noqa: B008
picker_service: PickerService = Depends(get_picker_service), # noqa: B008
feed_service: FeedService = Depends(get_feed_service), # noqa: B008
source_service: SourceService = Depends(get_source_service), # noqa: B008
) -> FullPickerResponse | None:
feed_service = request.app.state.job_service.feed_service
filter_service = request.app.state.job_service.filter_service
picker_service = request.app.state.job_service.picker_service
source_service = request.app.state.job_service.source_service

picker = picker_service.get_picker_by_external_id(external_id=picker_external_id)
if not picker:
raise HTTPException(status_code=404, detail="Picker not found")
Expand Down Expand Up @@ -832,11 +853,13 @@ def get_picker(
)
def delete_picker(
picker_external_id: UUID,
request: Request,
_: str = Depends(authenticate), # noqa: B008
filter_service: FilterService = Depends(get_filter_service), # noqa: B008
picker_service: PickerService = Depends(get_picker_service), # noqa: B008
job_service: JobService = Depends(get_job_service), # noqa: B008
):
filter_service = request.app.state.job_service.filter_service
picker_service = request.app.state.job_service.picker_service
job_service = request.app.state.job_service

picker = picker_service.get_picker_by_external_id(external_id=picker_external_id)
if not picker:
raise HTTPException(status_code=404, detail="Picker not found")
Expand Down
Loading
Loading