Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the transport layer and adds several tests that document flash operations and register updates. Key changes include:
- Addition of new test resource files for various flash operations (write, read, erase, etc.).
- Inclusion of detailed hex command logs in multiple files for deeper test validation.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| esp32-flash-lib/src/test/resources/write-flash-no-stub.txt | Adds test logs for flash writing without stubbing |
| esp32-flash-lib/src/test/resources/write-defl-flash-no-stub.txt | Adds test logs for deflated flash writing without stubbing |
| esp32-flash-lib/src/test/resources/update-reg.txt | Inserts test logs for updating registers |
| esp32-flash-lib/src/test/resources/set-flash-size.txt | Inserts test logs for setting flash size |
| esp32-flash-lib/src/test/resources/run-user-code.txt | Adds test logs for executing user code during flash operations |
| esp32-flash-lib/src/test/resources/read-flash-region.txt | Adds test logs for reading a flash region |
| esp32-flash-lib/src/test/resources/erase-flash-region.txt | Adds test logs for erasing a flash region |
| esp32-flash-lib/src/test/resources/end-flash.txt | Adds test logs marking the end of flash operations |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.