Skip to content

refactor: simplify codebase, fix release CI, consolidate tests#33

Merged
dkmnx merged 33 commits into
mainfrom
develop
May 14, 2026
Merged

refactor: simplify codebase, fix release CI, consolidate tests#33
dkmnx merged 33 commits into
mainfrom
develop

Conversation

@dkmnx
Copy link
Copy Markdown
Owner

@dkmnx dkmnx commented May 14, 2026

Changes

CI

  • Release workflow now extracts the versioned CHANGELOG section matching the git tag instead of relying on [Unreleased]
  • GoReleaser footer added for release artifacts

Refactor

  • Remove Windows ANSI platform detection (prompt_ansi.go, prompt_ansi_windows.go) — always emit color codes
  • Collapse migrateConfigFile sub-helpers (statOldConfig, readAndValidateConfig, etc.) into a single function
  • Inline root command execution, remove loadRootConfig/dispatchExecution indirection
  • Remove setup prompt injectable function variables, use tap directly
  • Remove unused helpers from cmd/util.go, cmd/update.go, cmd/harness.go, cmd/version.go
  • Add DecryptSecrets (string return) back alongside DecryptSecretsBytes
  • Expose ExecCommand in wrapper package

Tests

  • Consolidate coverage_config_test.go, coverage_env_test.go, test_helpers_test.go into coverage_test.go
  • Simplify setup_prompts_test.go — remove injectable tap function overrides
  • Update all tests to match refactored interfaces

Style

  • Add golangci-lint nlreturn exclusions for cmd and internal packages
  • Add funlen/cyclop exclusion for migrateConfigFile

Docs

  • Simplify AGENTS.md to essential project info

Stats

  • 42 files changed, 487 insertions, 1578 deletions
  • Net reduction: ~1100 lines

dkmnx and others added 30 commits April 25, 2026 23:55
@dkmnx
chore: merge branch 'main' into develop
7853318
@dkmnx
chore(release): remove stale goreleaser footer in favor of release-no…
79e5983 
…tes flag
@dkmnx
refactor(cmd): make tap/ui calls injectable, add test helpers and cov…
dd1ffeb 
…erage

fix(setup): swap validateConfiguredModel args to ValidateProviderModel
@dkmnx
fix(execution): call cleanup before exitProcess to prevent temp dir leak
518e9b7
@dkmnx
fix(env): sanitize hyphens in APIKeyEnvVarName to produce valid env vars
77f5b0e
@dkmnx
feat(version): add --no-update-check flag to skip GitHub API call
574de83
@dkmnx
fix(validate): replace panic in mustParseCIDR with log.Fatalf
dc92c6f
@dkmnx
refactor(cmd): load config through cache in delete and list commands
9b270f7
@dkmnx
refactor(wrapper): remove unused ExecCommand function
80a3c5c
@dkmnx
refactor(config): remove redundant CheckContext and ctx param from mi…
6d230f0 
…grateConfigFile
@dkmnx
deprecate(crypto): mark DecryptSecrets as deprecated, prefer DecryptS…
5de89f6 
…ecretsBytes
@dkmnx
fix(ui): add platform-based ANSI color fallback for Windows
3be44f2
@dkmnx
refactor(crypto): remove DecryptSecrets string return, fully migrate …
e662aa1 
…to DecryptSecretsBytes
@dkmnx
refactor(cmd): propagate parent context instead of context.Background()
de21da7
@dkmnx
refactor(root): decompose rootCmd.Run into runRoot, loadRootConfig, d…
dca9160 
…ispatchExecution
@dkmnx
refactor(lint): remove migrateConfigFile linter exemption after compl…
9b919c4 
…exity reduction
@dkmnx
fix(update): add TLS and response header timeouts to HTTP client tran…
95a6a1b 
…sport
@dkmnx
style: fix nlreturn violations and remove file-specific nlreturn exem…
d2ab6cd 
…ptions
@dkmnx
chore(lint): remove unused goconst exemption for cmd/delete.go
ed152be
@dkmnx
docs: add changelog entries for technical debt fixes
a78d7da
@dkmnx
feat(ui): detect Windows ANSI support via Virtual Terminal Processing
9d9a12d
@dkmnx
refactor(config): propagate context through migrateConfigFile
a24f701
@dkmnx
style(cmd): remove unused setup prompt variable
d3c1d49
@dkmnx
docs: regenerate AGENTS.md with architecture, conventions, and constr…
3387ad9 
…aints
@dkmnx
fix(ci): skip Unreleased section when extracting release notes
0304127 
The previous awk extracted the first ## [ section, which is always
[Unreleased]. At release time this section is empty, producing blank
release notes.
@dkmnx
chore: merge pull request #30 from dkmnx/develop
3e827ed 
Release v2.4.0
@dkmnx
fix(ci): extract versioned section from CHANGELOG for release notes
c53ad52
@dkmnx
style(lint): add nlreturn exclusions for cmd and internal packages
6a6d325
@dkmnx
refactor(ui): remove Windows ANSI detection, always emit color codes
c9b6432
@dkmnx
refactor(config): collapse migrateConfigFile sub-helpers into single …
3d5e93a 
…function
@dkmnx dkmnx merged commit 0b3709d into main May 14, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dkmnx