Skip to content

Tests for fix scoring PR - #6

Closed
zcsahok wants to merge 111 commits into
dl1jbe:masterfrom
zcsahok:tests_for_fix_scoring
Closed

zcsahok wants to merge 111 commits into
dl1jbe:masterfrom
zcsahok:tests_for_fix_scoring

Conversation

@zcsahok

@zcsahok zcsahok commented Jul 30, 2026

Copy link
Copy Markdown

Adding tests for rules mentioned in Tlf#390. Fixing rules as needed.

Starting with spdx_dx.

dl1jbe and others added 5 commits April 12, 2023 12:16
Was used for control of point scoring. By leaving all point controlling
keywords (besides COUNTRYLIST_POINTS) undefined the same result can be
achieved.
* Do some further cleanup  and
* adapt test code
@dl1jbe

dl1jbe commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Test for SPDX are failing as expected - USE_COUNTRY_LIST keyword not found.
Will add it back to parse_logcfg again with "Deprecated, please do not use any longer". Same for man page.

With the keyword dropped/ignored the tests succeed.

alandove and others added 24 commits July 31, 2026 18:12
* Changed MAX_SECTION_LENGTH to 5.
* rename spot.band to spot.bandindex and set band for new qso
* update man page for BANDMAP
* add CQ WW 160 rules
* make band limits configurable

* allow showing out-of-band spots on bandmap
Initial mode is controlled by the OPERATING_MODE configuration keyword.
* Remove 'DC' for states mults list as it is not a mult for this event.

* Break lines of all mult lists at ten entities per line for ease of counting.

* Add link to KSQP 2023 rules.
This year formerly combined entities are expanded into individual multipliers:
https://cqp.org/pdf/cqp2023_rules_changes.pdf
AC_PROG_CC_C99 and AC_HEADER_STDC are obsolete
As C standards does not define M_PI_2 provide a fallback and
factor out common definitions to math_utils.h
Use global declaration of _GNU_SOURCE via Makefile

That fixes some warnings about implicit function declarations for different compilers
* Fix getline usage (see Tlf#414)
…art (Tlf#416)

* Fix startup if HAMLIB_KEYER selected and rig is off or disabled at start

Otherwise TLF will abort unconditionally.
also fix bandswitch info sent to cwdaemon
* Terminate background thread gracefully

* fix background thread pause/resume action naming
The LOGFILE keyword needs to be in uppercase, or else the program will not start correctly.
* Cleans up an ambiguous example in the man page

Using parameter -f to 'pkill' kills the first program which contains the mentioned
'rec' string in its command line. That may not be the program with the
name 'rec'.

* Replace backticks with $() in scripts/soundlog

As backticks are generally hard to see, use the synonymous $() construct
to generate the name for the audio file.  $() is preferred for capturing
the output of a command into a shell variable.

---------

Co-authored-by: Nate Bargmann <n0nb@n0nb.us>
* add Marconi Club QSO Party Day

* set bandindex in qso created for a spot

* use initial exchanges for bandmap
df7cb and others added 24 commits July 31, 2026 18:12
There is little point in delaying startup when there are no
"interesting" messages. Remove sleep(1); the user can still request a
verbose run with `tlf -v` (this is the default on the first startup
anyway).

When having to restart tlf during a contest (after changing some setting
for example), that second actually makes a difference.
Respects major, minor and patch number
* use DIGIMODE if FLDIGI is set

* use rig_parse_mode() for DIGI_RIG_MODE

this value is transparent to TLF, let Hamlib do the parsing
allowing any supported mode

* add DIGITAL_MODE configuration for ADIF export

it's value is used in the MODE tag

reused and renamed modem_mode variable (it was used for RTTY only)

* use RY/DG for digimode in cabrillo depending on DIGITAL_MODE
This was previously only documented inside the github action.
When HAMLIB_KEYER is set, but rig control and keying is disabled via
`tlf -r`, hitting ESC will trip the assert(init_called) in
rig_has_stop_morse.

Protect the hamlib_keyer_* functions against being called in that mode.

In passing, decrease the timeout after showing the "keying disabled"
message to 1s.
* Fix implicit function declaration
* initialize errno
* Fix possible memory leak
* Limit bandmap_lookup to the list of displayed spots
* add test for 3-char prefix

* fix caching of 3-char+ prefixes
* hide search panel before changepars()

* apply chomp to rigport
* Drop now unused and undefined variable/type.

---------

Co-authored-by: George Baltz N3GB <GeoBaltz@gmail.com>
* generate TEST_RULES_FILES in test/generate_defs.pl

* add check_dist_dir to check a directory in distribution tar.gz

* execute tar.gz checking and make distcheck in CI jobs

* added missing rule files

(cherry picked from commit 8762fe4)

---------

Co-authored-by: Stephane Fillod <fillods@users.sf.net>
* Missing rule files

* Some precious hints for the iota rule, gleaned from past PR

* Documentation of a precious tool for handling Cbr and ADIF
* add callsign input field editing using insert_car/delete_char helper functions

* USEPARTIAL: do not trigger autofill on a number

* USEPARTIALS: move cursor to the end of the call + disable further fill on editing; 

* release blocking of partials if call is empty

* try to keep cursor position for trx memory operations

* move cursor after the call on fldigi grab

* fix underlining length when autosend is used

* update man page

* remove calledit.c

* remove legacy unused para_word
@zcsahok

zcsahok commented Jul 31, 2026

Copy link
Copy Markdown
Author

trying to follow rebasing

@zcsahok

zcsahok commented Jul 31, 2026

Copy link
Copy Markdown
Author

updated spdx_dx

  • set Cabrillo contest name
  • add SERIAL_OR_SECTION to get rid of annoying "section?" question
  • remove USE_COUNTRYLIST_ONLY

@dl1jbe

dl1jbe commented Aug 1, 2026

Copy link
Copy Markdown
Owner

May be it would be easier to drop my old and your new branch and start anew from the rebased one. Sorry for the inconvenience.

I will cherry-pick your SPDX_DX fixes first and will work from there.

@zcsahok

zcsahok commented Aug 1, 2026

Copy link
Copy Markdown
Author

continued in #7

@zcsahok zcsahok closed this Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.