Added operations#7
Open
Felipetoledo4815 wants to merge 4 commits into
Open
Conversation
dlshriver
requested changes
Jul 6, 2022
dlshriver
left a comment
dlshriver
left a comment
Owner
There was a problem hiding this comment.
Looks pretty good, only a couple small changes. I am going to wait to merge this until the new operators have been added to DNNV though.
|
|
||
| return unsqueeze | ||
|
|
||
| def visit_Upsample(self, operation: operations.Upsample): |
Owner
There was a problem hiding this comment.
Could you put these in alphabetical order?
| import dnnv.nn.operations as operations | ||
|
|
||
| output_shape = self.op_graph.output_shape[0] | ||
| # axis = 0 |
Owner
There was a problem hiding this comment.
please remove commented code
Suggested change
| # axis = 0 |
|
|
||
| return div | ||
|
|
||
| def visit_Squeeze(self, operation: operations.Squeeze): |
Owner
There was a problem hiding this comment.
Could you type all of the new operators using strings, e.g., def visit_Squeeze(self, operation: "operations.Squeeze"):. Otherwise, there will be errors for anyone not on the latest DNNV changes.
Owner
|
Please add a description when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.