Added Operations and tests#92
Conversation
added tests for Split Normalize line endings tests for Split added printvisitor for Split
Codecov Report
@@ Coverage Diff @@
## develop #92 +/- ##
===========================================
- Coverage 89.64% 89.38% -0.26%
===========================================
Files 138 138
Lines 8016 8199 +183
Branches 1491 1516 +25
===========================================
+ Hits 7186 7329 +143
- Misses 602 628 +26
- Partials 228 242 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dlshriver
left a comment
There was a problem hiding this comment.
Thank you for the pull request, these look like useful additions. I have several requested changes before merging that I'd like to see addressed. There is also currently a test failure that does not seem to be due to your changes that I'll look into to see if we can get the test suite to pass before merging as well.
| from dnnv.nn.converters.onnx import * | ||
| from dnnv.nn.operations import * | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you also add tests where each input to Squeeze can be an Input operation to ensure that the operation works with non-concrete input values? You can duplicate one of the test cases below and use input operations instead of concrete values to construct the op graph, and then pass the required values in when you call the op graph to get the outputs.
| from dnnv.nn.converters.tensorflow import * | ||
| from dnnv.nn.operations import * | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you also add tests where each input to Clip can be an Input operation to ensure that the operation works with non-concrete input values? You can duplicate one of the test cases below and use input operations instead of concrete values to construct the op graph, and then pass the required values in when you call the op graph to get the outputs.
| from dnnv.nn.converters.tensorflow import * | ||
| from dnnv.nn.operations import * | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you also add tests where each input to ReduceL2 can be an Input operation to ensure that the operation works with non-concrete input values? You can duplicate one of the test cases below and use input operations instead of concrete values to construct the op graph, and then pass the required values in when you call the op graph to get the outputs.
| from dnnv.nn.converters.tensorflow import * | ||
| from dnnv.nn.operations import * | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you also add tests where each input to Squeeze can be an Input operation to ensure that the operation works with non-concrete input values? You can duplicate one of the test cases below and use input operations instead of concrete values to construct the op graph, and then pass the required values in when you call the op graph to get the outputs.
| from dnnv.nn.converters.tensorflow import * | ||
| from dnnv.nn.operations import * | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you also add tests where each input to Upsample can be an Input operation to ensure that the operation works with non-concrete input values? You can duplicate one of the test cases below and use input operations instead of concrete values to construct the op graph, and then pass the required values in when you call the op graph to get the outputs.
|
Would you also add/edit your description of the pull request please, so that we can keep documentation on the changes that this should be making. |
Co-authored-by: David Shriver <davidshriver@outlook.com>
Co-authored-by: David Shriver <davidshriver@outlook.com>
Co-authored-by: David Shriver <davidshriver@outlook.com>
Co-authored-by: David Shriver <davidshriver@outlook.com>
Co-authored-by: David Shriver <davidshriver@outlook.com>
No description provided.