Fix NPE in emoji filter and enforce Locale.ROOT for case folding#102
Closed
Copilot wants to merge 2 commits intobolt-performance-emoji-optimization-10389537235408575973from
Closed
Fix NPE in emoji filter and enforce Locale.ROOT for case folding#102Copilot wants to merge 2 commits intobolt-performance-emoji-optimization-10389537235408575973from
Copilot wants to merge 2 commits intobolt-performance-emoji-optimization-10389537235408575973from
Conversation
Co-authored-by: dlukt <201112286+dlukt@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Optimize emoji search allocation in CustomEmojiPopupKeyboard
Fix NPE in emoji filter and enforce Locale.ROOT for case folding
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
performFilteringcalledcharSequence.toString()before the null check, risking an NPE on framework-initiated filter calls with a null constraint. Additionally,toLowerCase()without a locale was used in both the filter andgetLowerShortcode(), making matching locale-sensitive.Changes
CustomEmojiPopupKeyboard.java—performFilteringcharSequence.toString();searchis now computed only inside theelsebranchtoLowerCase(Locale.ROOT)import java.util.LocaleEmoji.java—getLowerShortcode()shortcode.toLowerCase(Locale.ROOT)so both sides of thecontains()check use the same localeimport java.util.Locale💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.