Recompute bounding shapes#2
Merged
Merged
Conversation
This was referenced Jun 16, 2023
Owner
|
This doesn't seem to be mergable (conflicts) |
Author
It's rebased on upstream master, didn't want to misrepresent their changes. Easiest would be to pull it in as another branch, GitHub sadly doesn't allow a PR to target a new branch. |
Owner
|
Are the commits in our fork still relevant? We can perhaps switch back to the original? |
Author
Sadly we can't switch back to the original. While some changes in our fork are superseded, the biggest one converting to ES6 classes is still needed (Experience-Monks#41, Experience-Monks#46, Experience-Monks#49) Not to mention the additional bug fix of recomputing the bounding shapes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR that addresses the underlying problem of aframevr/aframe#5311. Whenever the
updatemethod on theTextGeometryis called, theboundingBoxandboundingSpherewill now be recomputed (if present). This is the same logic thatBufferGeometryandLineSegmentsGeometryuse.Note: this PR can't be automatically merged as I rebased it onto the latest master of the original repository (https://github.com/Jam3/three-bmfont-text). This included a couple of nice clean-ups, like the removal of the dependency on https://github.com/Jam3/three-buffer-vertex-data and the
object-assignponyfill. For easier reviewing, please see: