Conversation
Extract encoding logic from Exec into reusable encodeTitle function.
Owner
|
I am still looking at this but so far it looks okay. I am still thinking through the side effects. Is the idea that this is just a way to repeat encoding against files ripped on a previous run? What about automations? Are you envisioning those to run again? |
Author
Yes. The use case is that you discovered that your config was bad, and you changed it, and then deceide to do a redo of the same rip.
Yes, those could run again. But feels out of scope for the main feature, because it could be configurable with a flag for the redo command itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Execinto reusableencodeTitle()function (encode.go)Redo()function that re-encodes titles from a previous run using the current config's encoding settings (redo.go)listManifestFiles()fromPrintHistoryfor reuse across history and redo flowsDetails
Redo reads a manifest from run history, verifies the original ripped MKV files still exist on disk, then re-encodes selected titles with the current config. If raw files were deleted, it exits with a message suggesting the user re-rip. Output goes to a new timestamped directory. Results are recorded in a new manifest entry.
The command is not included, but here is my version:
Code from https://git.sr.ht/~timharek/handymkv/tree/main/item/cmd/handymkv/redo.go