Skip to content

Separate domain for satellite image and nowcast output#10

Open
KristianHMoller wants to merge 4 commits intodmidk:mainfrom
KristianHMoller:feature/larger_satellite_domain
Open

Separate domain for satellite image and nowcast output#10
KristianHMoller wants to merge 4 commits intodmidk:mainfrom
KristianHMoller:feature/larger_satellite_domain

Conversation

@KristianHMoller
Copy link
Copy Markdown
Contributor

Currently, the nowcast is provided on the same domain as the satellite image. This results in odd effects where the NaN values from outside the domain of the satellite image are blown into the domain of interest.

This PR allows for separation of the domains for satellite images and nowcast output, so that a larger domain can be used for the satellite image.

Based on back-of-the-envelope calculations assuming maximum (relevant) cloud velocities of 100 km/h, the domain NW_EUROPE_SATELLITE has been introduced as an example of a domain which can be used for producing nowcasts on the NW_EUROPE domain. The new domain extends 10 degrees outside of NW_EUROPE to all sides.

@KristianHMoller
Copy link
Copy Markdown
Contributor Author

@irenelivia you are our cloud expert - does the additional extent of the NW_EUROPE_SATELLITE domain sound reasonable?

@KristianHMoller
Copy link
Copy Markdown
Contributor Author

Comparison showing the output on the NW_EUROPE domain after 5 hours of forecast time. Left uses the larger NW_EUROPE_SATELLITE domain for the satellite image and right uses the same domain for the satellite image and nowcast.
nowcast_5h_comparison

@irenelivia
Copy link
Copy Markdown
Collaborator

@KristianHMoller great work! My only consideration is that the nowcast ultimately changes if we use a larger domain (or a smaller domain, for that matter). You can see it in the case you showed - the advected clouds don't have the same exact shape in the two nowcasts run with different domains. So, we are ultimately providing a new model that we have not validated, and before making this kind of change, we should ideally "prove" that it improves the scores (or, at least, does not worsen them) over Denmark.

@KristianHMoller
Copy link
Copy Markdown
Contributor Author

Will need updating to be compatible with this (much needed) functionality: #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants