Separate domain for satellite image and nowcast output#10
Open
KristianHMoller wants to merge 4 commits intodmidk:mainfrom
Open
Separate domain for satellite image and nowcast output#10KristianHMoller wants to merge 4 commits intodmidk:mainfrom
KristianHMoller wants to merge 4 commits intodmidk:mainfrom
Conversation
Contributor
Author
|
@irenelivia you are our cloud expert - does the additional extent of the |
Contributor
Author
Collaborator
|
@KristianHMoller great work! My only consideration is that the nowcast ultimately changes if we use a larger domain (or a smaller domain, for that matter). You can see it in the case you showed - the advected clouds don't have the same exact shape in the two nowcasts run with different domains. So, we are ultimately providing a new model that we have not validated, and before making this kind of change, we should ideally "prove" that it improves the scores (or, at least, does not worsen them) over Denmark. |
Contributor
Author
|
Will need updating to be compatible with this (much needed) functionality: #11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Currently, the nowcast is provided on the same domain as the satellite image. This results in odd effects where the NaN values from outside the domain of the satellite image are blown into the domain of interest.
This PR allows for separation of the domains for satellite images and nowcast output, so that a larger domain can be used for the satellite image.
Based on back-of-the-envelope calculations assuming maximum (relevant) cloud velocities of 100 km/h, the domain NW_EUROPE_SATELLITE has been introduced as an example of a domain which can be used for producing nowcasts on the NW_EUROPE domain. The new domain extends 10 degrees outside of NW_EUROPE to all sides.