Add kDLBComplex type to DLDataTypeCode#187
Merged
Merged
Conversation
tqchen
approved these changes
May 3, 2026
Member
|
cc @leofang |
hpkfft
reviewed
May 26, 2026
| /*! \brief complex number (2x bfloat16) | ||
| * (C/C++/Python layout: same as kDLComplex, compact struct per complex number) | ||
| */ | ||
| kDLBComplex = 18U, |
There was a problem hiding this comment.
Since the enumeration kDLBfloat does not use an uppercase F, I would suggest kDLBcomplex.
Collaborator
Author
There was a problem hiding this comment.
On reflection, I think that's better indeed. All names currently have a single capital letter after kDL.
Collaborator
Author
There was a problem hiding this comment.
I'll change it if there are no objections.
|
It looks like everyone agrees/approves (both here and in the RFC). |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-184