Fix Monorepo tsconfig Resolution#79
Open
alegian wants to merge 1 commit intodmmulroy:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here are the results of the old tsconfig resolution command (in Monorepos):
the problem is that the pattern matches too broadly, including arbitrary json files in folders with names containing
tsconfig. This in turn causestscto crash because the tsconfig "has invalid structure" (because it resolved to my package.json...)so i fixed the ripgrep command.
the second change regarding the
findcommand was an accidental discovery: the command literally didnt work because it required that the dot in (.*) always exists.i tested both new commands on my system and they correctly resolve the configs.
DISCLAIMER: i have not tested the TSC tool itself, because I dont know how