Fixes: #219 typo in Japanese post rules - #220
Conversation
Changed `u` to `ɯ` in one rule in both `data/post/jpn-Hira.txt` and `data/post/jpn-Kana.txt`.
|
Hi, thanks a lot for your efforts! If it's possible, can you add the aforementioned Tokyo example as a test case? Thanks! |
|
It doesn't seem like there's a test file for Japanese yet, is there any documentation on how to set one up? (Especially since there's three different scripts) |
|
Thanks!! There's no documentation yet, but a good example will be https://github.com/dmort27/epitran/blob/master/epitran/test/test_slovene.py or https://github.com/dmort27/epitran/blob/master/epitran/test/test_finnish.py The test file's name should always be "test_something.py", in this case, "test_japanese.py" at that folder. |
|
FYI, you pushed bunch of Turkish in this PR! |
|
Whoops, sorry, that commit was meant for my fork! |
|
I've tried adding a test file, but I'm not sure if I've done it right. I couldn't tell from the example files how to go about adding tests for multiple scripts (should they be in separate files?), so I've only done the Hiragana case for now. |
|
You can do something similar like: https://github.com/dmort27/epitran/blob/master/epitran/test/test_slovene.py#L25-L39 |
Bug fix, fixes: #219. Changed
utoɯin one rule in bothdata/post/jpn-Hira.txtanddata/post/jpn-Kana.txt.See #219: words like とうきょう/トウキョウ are incorrectly transcribed as /toukʲou/ rather than /toːkʲoː/.
See above.
This will have a substantial effect on output transcriptions.