-
Notifications
You must be signed in to change notification settings - Fork 348
fetch: support wildcard and CIDR patterns in domain allow/deny lists #2602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dgageot
wants to merge
5
commits into
docker:main
Choose a base branch
from
dgageot:board/fetch-toolset-deny-host-list-inquiry-50ebcbd9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
37d8c39
support wildcard and CIDR patterns in fetch allow/deny lists
dgageot a6f3853
fix IPv4-mapped IPv6 SSRF bypass in fetch domain matcher
dgageot e2cd419
update docs to reflect IPv4-mapped IPv6 normalization
dgageot cc5fbde
add edge case tests for domain matcher
dgageot f2a73ee
gofmt fetch_test.go
dgageot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LOW] Inconsistency: non-CIDR IP normalisation path does not strip trailing dot before
net.ParseIPThe CIDR path (line 331) correctly chains both bracket-stripping and trailing-dot stripping before calling
net.ParseIP:The non-CIDR normalisation path (line 355) only strips brackets, not the trailing dot:
For a host like
[::ffff:169.254.169.254].(bracketed IPv6 with FQDN trailing dot),strings.Trim(host, "[]")yields::ffff:169.254.169.254].(the trailing.is not in the cutset"[]"), sonet.ParseIPreturns nil and the host falls through un-normalised to the string comparison stage. The bypass is theoretical in practice sinceurl.Hostname()strips brackets and would not return a host in this form — but the inconsistency between the two paths in the changed code is real.Suggested fix: Apply the same pattern as the CIDR path: