Skip to content

feat: add DOCLINGCORE_ALLOWED_PRIVATE_IPS setting to allow private IPs#608

Open
COTHSC wants to merge 1 commit into
docling-project:mainfrom
COTHSC:feat/allowed-private-ips
Open

feat: add DOCLINGCORE_ALLOWED_PRIVATE_IPS setting to allow private IPs#608
COTHSC wants to merge 1 commit into
docling-project:mainfrom
COTHSC:feat/allowed-private-ips

Conversation

@COTHSC

@COTHSC COTHSC commented May 11, 2026

Copy link
Copy Markdown

Closes #599

Adds an optional "allowed_private_ips" to CoreSettings to specify safe internal IPs as described in the issue
Default behaviour is unchanged

… access

Signed-off-by: COTHSC <thierryscully.colomban@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

DCO Check Passed

Thanks @COTHSC, all your commits are properly signed off. 🎉

@mergify

mergify Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 1 of 2 protections blocking · waiting on 👀 reviews

Protection Waiting on
🔴 Require two reviewer for test updates 👀 reviews
🟢 Enforce conventional commit

🔴 Require two reviewer for test updates

Waiting for

  • #approved-reviews-by >= 2
This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

Show 1 satisfied protection

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@PeterStaar-IBM PeterStaar-IBM requested a review from dolfim-ibm May 12, 2026 09:19
@JViktoRArtola

Copy link
Copy Markdown

Is there a planned release window for this? I’d be happy to help test or contribute if that would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow configurable IP allowlist for _is_safe_url() to support private network access

2 participants