feat: add page metadata support#647
Open
gyx09212214-prog wants to merge 2 commits into
Open
Conversation
Contributor
|
✅ DCO Check Passed Thanks @gyx09212214-prog, all your commits are properly signed off. 🎉 |
…og@users.noreply.github.com> I, gyx09212214-prog <243787584+gyx09212214-prog@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 480883d Signed-off-by: gyx09212214-prog <243787584+gyx09212214-prog@users.noreply.github.com>
Contributor
Merge Protections🔴 1 of 2 protections blocking · waiting on 👀 reviews
🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PageMetaas the page-level metadata modelPageItemandDoclingDocument.add_page(...)to carry optional page metadataWhy
Refs docling-project/docling#1005.
Floating items already expose
meta, but pages did not have an equivalent metadata slot. This gives downstream document hierarchy, Doc2KG, and RAG pipelines a structured place to carry page-level summaries, entities, source-scope tags, or other namespaced metadata without changing default output when no metadata is supplied.Tests
python -m pytest test\test_serialization.py -qpython -m ruff check docling_core\types\doc\document.py docling_core\types\doc\__init__.py test\test_serialization.pypython -m ruff format --check docling_core\types\doc\document.py docling_core\types\doc\__init__.py test\test_serialization.pypython -m py_compile docling_core\types\doc\document.py docling_core\types\doc\__init__.py test\test_serialization.pygit diff --check