feat: add get_cell_image method to TableItem#652
Open
sriharan0804 wants to merge 1 commit into
Open
Conversation
Contributor
|
✅ DCO Check Passed Thanks @sriharan0804, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🔴 1 of 2 protections blocking · waiting on 👀 reviews
🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
e92fb65 to
7d4c7e8
Compare
|
@dolfim-ibm please review. |
Contributor
Author
|
hi @christymanthara , take a look at this PR |
Signed-off-by: sriharan2005@Tamil-- <sriharan0804@users.noreply.github.com>
7d4c7e8 to
ec5ad1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #449
This PR adds a
get_cell_image()helper method toTableItemto enable extraction of image crops corresponding to individual table cells.Currently,
TableCellobjects may contain bounding box information, but there is no direct API for retrieving the image region represented by a cell. This change provides a convenient way to obtain cell-level image crops from the underlying page image.Changes
Added
TableItem.get_cell_image()Reused the existing image cropping workflow used by
DocItem.get_image()Added validation for:
Returns
Nonewhen image extraction is not possibleImplementation Details
The method:
This follows the same coordinate conversion and image extraction logic already used elsewhere in the document model.
Testing
Added a unit test covering successful table cell image extraction.
Executed:
uv run pytest test/test_docling_doc.py -k "get_cell_image" -vResult:
Additional verification:
uv run pytest test/test_docling_doc.py -k "table" -vResult:
Linting:
Result: