fix: normalize image reference paths to POSIX format#663
Open
sriharan0804 wants to merge 1 commit into
Open
Conversation
Signed-off-by: sriharan2005@Tamil-- <sriharan0804@users.noreply.github.com>
Contributor
|
✅ DCO Check Passed Thanks @sriharan0804, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Windows-specific image reference paths when exporting documents with referenced images.
Currently, image URIs are stored using the platform-specific path separator. On Windows this results in backslashes (
\), which are URL-encoded as%5Cin HTML output and also appear in Markdown image references.This change normalizes the generated image URI to POSIX format using
Path(...).as_posix(), ensuring consistent forward-slash (/) separators across platforms.Changes
Path(obj_path).as_posix().Testing
/instead of\(or%5Cin HTML).