feat: assign ContentLayer.SHEET to Excel worksheet groups#3700
Closed
samiuc wants to merge 1 commit into
Closed
Conversation
Signed-off-by: samiuc <sami.ullah.chat@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @samiuc, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
@samiuc Please, check my comment in the companion PR of docling-core docling-project/docling-core#660 (comment) , since I don't think we need a new content layer for workbook sheets. |
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent PR: docling-project/docling-core#660
When converting a multi-sheet Excel file, there was no way to tell which table or piece of content belonged to which worksheet. This PR fixes that by ensuring visible sheets carry a dedicated content layer that serializers can act on, and adds a test to verify the behavior end to end.
Checklist: