Work around a breakpad bug on Windows#329
Draft
RichardTea wants to merge 3 commits intodocsteer:3.0-devfrom
Draft
Work around a breakpad bug on Windows#329RichardTea wants to merge 3 commits intodocsteer:3.0-devfrom
RichardTea wants to merge 3 commits intodocsteer:3.0-devfrom
Conversation
This reverts commit 7456834.
Does not fix the Windows bug Will make it easier to retest when the next depot_tools change happens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breakpad updated to Python3 and this appears to have broken Google depot_tools fetch.bat and gclient.bat on Windows.
Sadly, updating depot_tools alone was not enough!
Work around the issue by:
gclient.bat synccall to fail without aborting the buildThis workaround can be removed once upstream fixes the issue.