Skip to content

refactor: remove local state tracking for generated SHAs and simplify baseline determination in check command #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alessiopelliccione merged 2 commits into from
Dec 20, 2025
Merged

refactor: remove local state tracking for generated SHAs and simplify baseline determination in check command #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e8626f
refactor: remove local state tracking for generated SHAs and simplify…
alessiopelliccione Dec 20, 2025
a39a94f
ci: exclude sintesi state files from cache path
alessiopelliccione Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/sintesi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ jobs:
path: |
.sintesi
!.sintesi/lineage.json
!.sintesi/*.state.json
key: sintesi-state-${{ runner.os }}-${{ github.sha }}
restore-keys: |
sintesi-state-${{ runner.os }}-
Expand Down
42 changes: 4 additions & 38 deletions packages/cli/src/commands/check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { SmartChecker } from '../services/smart-checker';
import { GenerationContextService } from '../services/generation-context';
import { LineageService } from '../services/lineage-service';
import { SemanticVerifier } from '../services/semantic-verifier';
import { existsSync, mkdirSync, writeFileSync, readdirSync, readFileSync } from 'fs';
import { existsSync, mkdirSync, writeFileSync, readdirSync } from 'fs';
import { resolve, join, relative } from 'path';

import { execSync } from 'child_process';
Expand Down Expand Up @@ -52,48 +52,16 @@ export async function checkCommand(options: CheckOptions): Promise<CheckResult>
};
}

// Load detailed state to check for last logic
let lastDocSha: string | undefined;
let lastReadmeSha: string | undefined;

// Load Lineage Service early to check for shared baseline
const lineageService = new LineageService(logger, codeRoot);
const lineageSha = lineageService.getLastGeneratedSha();

try {
const sintesiDir = resolve(process.cwd(), '.sintesi');
if (existsSync(join(sintesiDir, 'documentation.state.json'))) {
const docState = JSON.parse(
readFileSync(join(sintesiDir, 'documentation.state.json'), 'utf-8'),
);
if (docState.lastGeneratedSha) {
lastDocSha = docState.lastGeneratedSha;
logger.info(
`Found previous documentation state (SHA: ${(docState.lastGeneratedSha as string).substring(0, 7)})`,
);
}
}
if (existsSync(join(sintesiDir, 'readme.state.json'))) {
const readmeState = JSON.parse(
readFileSync(join(sintesiDir, 'readme.state.json'), 'utf-8'),
);
if (readmeState.lastGeneratedSha) {
lastReadmeSha = readmeState.lastGeneratedSha;
}
}
} catch (e) {
logger.debug(`Failed to load previous state: ${e}`);
}

// Determine Base Ref
// If user provided --base, use it. Otherwise use last SHA if available.
// Note: If checking BOTH, and they have different SHAs, we might have a conflict if asking for a single "changes" analysis.
// 'analyzeProject' returns a single git diff.
// If user provided --base, use it. Otherwise use Lineage SHA.
// Priority:
// 1. Explicit --base flag
// 2. Lineage SHA (Shared/Committed baseline)
// 3. Local State SHA (Local ephemeral state)
const baseRef = options.base || lineageSha || lastDocSha || lastReadmeSha;
const baseRef = options.base || lineageSha;

if (baseRef && !options.base) {
logger.info(
Expand Down Expand Up @@ -178,7 +146,7 @@ export async function checkCommand(options: CheckOptions): Promise<CheckResult>
logger.info('Performing smart check (README vs Code)...');
const smartChecker = new SmartChecker(logger, codeRoot);
const smartResult = await smartChecker.checkReadme({
baseBranch: options.base || lastReadmeSha, // Use specific SHA for readme if available
baseBranch: options.base || lineageSha, // Prioritize explicit base, then lineage
readmePath: resolve(codeRoot, options.output || 'README.md'),
});

Expand Down Expand Up @@ -342,7 +310,6 @@ export async function checkCommand(options: CheckOptions): Promise<CheckResult>
JSON.stringify(
{
timestamp: Date.now(),
lastGeneratedSha: lastReadmeSha, // Preserve SHA
readme: {
hasDrift: readmeDriftDetected,
reason: readmeReason,
Expand All @@ -364,7 +331,6 @@ export async function checkCommand(options: CheckOptions): Promise<CheckResult>
JSON.stringify(
{
timestamp: Date.now(),
lastGeneratedSha: lastDocSha, // Preserve SHA
documentation: {
hasDrift: docDriftDetected,
reason: docReason,
Expand Down
1 change: 0 additions & 1 deletion packages/cli/src/commands/documentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ export async function documentationCommand(options: DocumentationOptions): Promi
JSON.stringify(
{
timestamp: Date.now(),
lastGeneratedSha: currentSha,
documentation: {
hasDrift: false,
reason: null,
Expand Down