fix: update cache in-memory state after write operations#47
Draft
notJoon wants to merge 2 commits intododok8:mainfrom
Draft
fix: update cache in-memory state after write operations#47notJoon wants to merge 2 commits intododok8:mainfrom
notJoon wants to merge 2 commits intododok8:mainfrom
Conversation
Owner
|
As #52 is merged, it made large changes to the main branch. I recommend merge main branch again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache
set/remove/clearmethods did not update in-memory state after writing to disk, causing stale reads within the same process. This PR fixes the inconsistency and adds regression tests.Changes
set,remove,clearsignatures from&selfto&mut selfso in-memory state can be mutated&mut selfrequirement to callers infetcher,generator,main,init, andwatchertest_cache_set_visible_immediately_in_same_processandtest_cache_remove_visible_immediately_in_same_processregression testsRelated Issues
None
Checklist
cargo test --all-featurespassescargo clippy --all-targets --all-features -- -D warningspassescargo fmt --all --checkpasses