Skip to content

fix: Some pages do not support i18n.#43

Merged
doganarif merged 2 commits into
doganarif:mainfrom
lxdklp:main
Nov 21, 2025
Merged

fix: Some pages do not support i18n.#43
doganarif merged 2 commits into
doganarif:mainfrom
lxdklp:main

Conversation

@lxdklp
Copy link
Copy Markdown
Contributor

@lxdklp lxdklp commented Nov 20, 2025

Pull Request

Description

Add support for pages that do not have i18n support

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test coverage improvement

Changes Made

Add i18n support to the following pages

  • Layout.tsx
  • BackgroundTasksPage.tsx
  • TracesList.tsx

The i18n translation on the following pages has been changed.

  • DashboardPage.tsx
  • RequestsPage.tsx
  • PerformancePage.tsx

Update files

  • translations.ts
  • index.html
  • index-DXB6avHW.js

Testing

  • All existing tests pass
  • New tests added for new functionality
  • Manual testing completed
  • Test coverage >= 90%

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Summary by cubic

Adds i18n support to pages that were missing it and replaces hardcoded UI text with translations. This ensures consistent localization across the dashboard.

  • Bug Fixes
    • Added useT and translations for Layout, TracesList, and BackgroundTasks (errors, filters, statuses, labels).
    • Localized labels in Dashboard (Success/Errors/P50), Performance (query score, no slow queries), and Requests (apply filters, time range).
    • Expanded translations.ts with new keys for EN and ZH.
    • Updated dist index.html to reference the new bundle and renamed the JS asset.

Written for commit 449afc7. Summary will update automatically on new commits.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @lxdklp, your pull request is larger than the review limit of 150000 diff characters

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 9 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="fastapi_radar/dashboard/src/components/TracesList.tsx">

<violation number="1" location="fastapi_radar/dashboard/src/components/TracesList.tsx:154">
`SelectValue` uses the nonexistent key `traceslist.allStatuses`, so the placeholder renders the raw key instead of a translation.</violation>
</file>

Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Ask questions if you need clarification on any suggestion

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

Comment thread fastapi_radar/dashboard/src/components/TracesList.tsx Outdated
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

@doganarif doganarif merged commit ff32926 into doganarif:main Nov 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants