Skip to content

Conversation

@ThePixelbrain
Copy link
Collaborator

This PR adds support for MC 1.4.x and 1.5.x. This is achieved by expanding the coremod functionality of this mod.

To explain wtf is even going on in this PR, a quick history lesson of Forge and FML:

MC 1.4 and 1.5 used the Relauncher, a hack that hijacks the game launch early on, creates a new classloader and launches the game again inside the RelaunchClassLoader. Therefore, ASM transformers had to be done through cpw.mods.fml.relauncher.IClassTransformer.

With MC 1.6 the new launcher was released. This was called Launchwrapper and is also known as LegacyLauncher now. Since then, ASM transformers had to be registered to net.minecraft.launchwrapper.IClassTransformer. This means that MC 1.6 has always been supported, we just never said so in our README.

This PR lets the game deside what Class Transformer it needs by checking what transformer is available in the classpath.

I also added new patches to vulnerable mods:

  • LogisticPipes was vulnerable in 1.4.7, however the class path was different from later versions and wasn't part of the classesToPatch
  • VoxelPacket (a library used by voxel mods) is also vulnerable. I really have no clue what versions are vulnerable, as I could find zero distribution of these to check the versions. (Only version I could find was in 1.4.7 FTB modpacks.) For now we should just assume all versions are vulnerable.

I can update the documentation (README.md and mods.md) after this has been merged, but as mods.md contains links to the patches, I couldn't be asked to do this twice.

@ThePixelbrain ThePixelbrain requested a review from dogboy21 March 15, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants