Add missing handshake messages when upgrading to WebSocket, fixes #380#399
Open
bajasoft wants to merge 1 commit intodoghappy:masterfrom
Open
Add missing handshake messages when upgrading to WebSocket, fixes #380#399bajasoft wants to merge 1 commit intodoghappy:masterfrom
bajasoft wants to merge 1 commit intodoghappy:masterfrom
Conversation
bajasoft
force-pushed
the
websocket-upgrade-handshake
branch
from
c4c4c65 to
1f98e89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes compatibility issue with python-socketio server by implementing missing probe request/response handshake as described in the protocol upgrade documentation.