Skip to content

Improve decompilation matches - #3259

Merged
ribbanya merged 3 commits into
doldecomp:masterfrom
dberweger2017:decomp-match-improvements
Aug 30, 2026
Merged

Improve decompilation matches#3259
ribbanya merged 3 commits into
doldecomp:masterfrom
dberweger2017:decomp-match-improvements

Conversation

@dberweger2017

Copy link
Copy Markdown
Contributor

Improves matching across several functions.

@dberweger2017
dberweger2017 marked this pull request as draft August 30, 2026 11:29
@decomp-dev

decomp-dev Bot commented Aug 30, 2026

Copy link
Copy Markdown

Report for GALE01 (175e428 - 76ad47a)

📈 Matched code: 92.72% (+0.65%, +25380 bytes)
📈 Matched data: 96.73% (+0.01%, +88 bytes)

✅ 28 new matches
Unit Item Bytes Before After
main/melee/mn/mnevent mnEvent_8024D15C +87 90.42% 100.00%
main/melee/ty/tyfigupon _tyFigupon_80315C44 +62 95.36% 100.00%
main/melee/gm/gmresult fn_80175240 +55 93.33% 100.00%
main/melee/ft/chara/ftCommon/ftCo_0A01 ftCo_800ADE48 +53 97.80% 100.00%
main/melee/gm/gmresult fn_80174468 +41 96.51% 100.00%
main/melee/gm/gmtoulib fn_8018DF68 +36 97.24% 100.00%
main/melee/gm/gmallstar gm_801B5624 +35 96.23% 100.00%
main/melee/gm/gmregclear gm_80182578 +26 98.29% 100.00%
main/melee/mn/mninfo mnInfo_80252758 +25 94.11% 100.00%
main/sysdolphin/baselib/debugconsole_main hsd_80396884 +25 94.09% 100.00%
main/melee/gm/gmtoulib fn_8018DC18 +22 97.49% 100.00%
main/melee/mn/mnnamenew WriteCharactersForNameAtIndex +20 94.61% 100.00%
main/melee/gm/gmclassic gmClassic_801B2BA4 +13 97.13% 100.00%
main/melee/gm/gm_16A2 fn_80169F50 +10 97.29% 100.00%
main/melee/gm/gmtoulib fn_8018C8D4 +10 99.70% 100.00%
main/melee/gr/granime grAnime_801C7228 +8 99.07% 100.00%
main/sysdolphin/baselib/debugconsole_main hsd_80394544 +8 97.53% 100.00%
main/melee/mn/mnnamenew fn_8023DBE8 +7 99.48% 100.00%
main/melee/mn/mnsnap mnSnap_80253F60 +7 96.22% 100.00%
main/melee/ft/chara/ftCommon/ftCo_0A01 ftCo_800A6700 +6 99.46% 100.00%
main/sysdolphin/baselib/hsd_3915 hsd_8039254C +6 99.43% 100.00%
main/melee/gr/grgreens grGreens_802159B8 +5 98.96% 100.00%
main/melee/mn/mndiagram2 mnDiagram2_Create +4 99.40% 100.00%
main/melee/ft/chara/ftCommon/ftCo_0D95 fn_800D9930 +2 99.83% 100.00%
main/melee/gr/grgreens grGreens_80215ED8 +2 99.93% 100.00%
main/melee/gm/gmregclear fn_80181E18 +1 99.90% 100.00%
main/sysdolphin/baselib/hsd_3B34 extab +1 97.50% 100.00%
main/sysdolphin/baselib/hsd_3B5C extabindex +1 97.92% 100.00%
📈 103 improvements in unmatched items
Unit Item Bytes Before After
main/melee/if/ifstatus ifStatus_802F4EDC +514 83.27% 99.47%
main/melee/mn/mnevent fn_8024D864 +243 89.48% 99.67%
main/melee/if/ifstock ifStock_802F8298 +182 86.25% 95.87%
main/melee/gr/grzebes grZebes_801DBB60 +160 90.53% 99.44%
main/melee/if/ifstock ifStock_802F7EFC +151 83.62% 99.91%
main/melee/gm/gmmain_lib gmMainLib_8015DBF4 +148 95.76% 99.76%
main/melee/ft/ftafterimage ftCo_800C2600 +145 91.48% 97.23%
main/melee/gr/grzebes grZebes_801DB3CC +137 91.98% 99.03%
main/melee/ty/toy _Toy_8030E110 +116 98.11% 99.91%
main/melee/gr/grzebes grZebes_801DB088 +106 86.78% 99.43%
main/melee/gr/grbigblue grBigBlue_801EE398 +96 95.10% 98.36%
main/melee/gm/gmresultplayer fn_8017AA78 +94 80.33% 94.67%
main/melee/mn/mnruleplus mn_80233218 +85 93.08% 97.31%
main/melee/gm/gm_1832 fn_80186634 +82 95.85% 99.99%
main/sysdolphin/baselib/hsd_3B34 hsd_803B51C8 +82 96.76% 99.84%
main/melee/ft/chara/ftCommon/ftCo_0A01 ftCo_800A75DC +80 93.40% 99.90%
main/sysdolphin/baselib/hsd_3B5C hsd_803B6BE4 +80 94.00% 98.96%
main/melee/ty/toy _Toy_8030B530 +71 99.28% 99.91%
main/sysdolphin/baselib/particle hsd_8039930C +64 94.45% 94.87%
main/melee/mn/mnmainrule mn_80230E38 +63 96.66% 99.72%
main/melee/ft/chara/ftCommon/ftCo_0A01 ftCo_800A7AAC +59 96.28% 99.96%
main/melee/gr/grzebes grZebes_801D881C +57 96.19% 98.71%
main/melee/ty/toy _Toy_80309404 +56 99.20% 99.87%
main/melee/gm/gmtoulib fn_8018A514 +48 94.27% 98.60%
main/melee/mn/mnstagesw mnStageSw_80236CBC +47 97.42% 99.90%
main/melee/gm/gmclassic gm_Mode_Classic_OnLoad +42 92.65% 95.81%
main/sysdolphin/baselib/generator hsd_8039DAD4 +42 97.51% 98.38%
main/sysdolphin/baselib/hsd_3B34 hsd_803B3408 +42 81.29% 86.09%
main/melee/ft/ftcpuattack ftCo_800B5AB0 +41 97.74% 99.92%
main/melee/gr/grmutecity grMuteCity_801F1A34 +40 98.81% 99.88%

...and 73 more improvements in unmatched items

ribbanya
ribbanya previously approved these changes Aug 30, 2026

@ribbanya ribbanya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of this is a little sus, particularly the macros like GRBB_ROUTE_ENTRY_AT, but it's fine as a first pass. Please mark as ready when you want me to merge.

@ribbanya
ribbanya force-pushed the decomp-match-improvements branch from 03cd2c7 to 76ad47a Compare August 30, 2026 13:02
@dberweger2017
dberweger2017 marked this pull request as ready for review August 30, 2026 13:39
@ribbanya ribbanya added the ai-assisted Utilizes a LLM to do the heavy lifting label Aug 30, 2026
@ribbanya
ribbanya merged commit 05b5ee2 into doldecomp:master Aug 30, 2026
12 checks passed
@dberweger2017
dberweger2017 deleted the decomp-match-improvements branch August 30, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Utilizes a LLM to do the heavy lifting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants