Some RPSystem TU's

[ThePlayerRolo]

Currently RPSysQueue is linked with RP_80186E40 being merged with RPSysLoadScene.

I tried to define RP_80186E40 as a seperate tu but since the lbl for it is never used anywhere it gets optimized out, leading to linking errors.

I assume its apart of RPSysLoadScene due to its position in text, however if you think otherwise I can undo it

[decomp-dev]

Report for RSPE01_01 (eb5969b - 4e92789)

📈 Matched code: 33.97% (+0.01%, +304 bytes)
📈 Linked code: 28.10% (+0.01%, +188 bytes)
📈 Matched data: 37.55% (+0.00%, +4 bytes)
📈 Linked data: 54.07% (+0.00%, +24 bytes)

✅ 6 new matches

Unit	Item	Bytes	Before	After
main/Pack/RPSystem/RPSysQueuedScene	RPSysQueuedScene::CreateInstance(EGG::Heap*)	+112	0.00%	100.00%
main/Pack/RPSystem/RPSysLoadScene	__sinit_\RPSysLoadScene_cpp	+88	0.00%	100.00%
main/Pack/RPSystem/RPSysQueuedScene	RPSysQueuedScene::~RPSysQueuedScene()	+64	0.00%	100.00%
main/Pack/RPSystem/RPSysLoadScene	__arraydtor$25785	+28	0.00%	100.00%
main/Pack/RPSystem/RPSysQueuedScene	RPSysQueuedScene::reset()	+12	0.00%	100.00%
main/Pack/RPSystem/RPSysLoadScene	.ctors	+4	0.00%	100.00%

📈 3 improvements in unmatched items

Unit	Item	Bytes	Before	After
main/Pack/RPSystem/RPSysLoadScene	.bss	+60	0.00%	93.75%
main/Pack/RPSystem/RPSysQueuedScene	.data	+13	0.00%	85.71%
main/Pack/RPSystem/RPSysQueuedScene	.sbss	+5	0.00%	66.67%

[kiwi515]

hi, thank you- i appreciate the pr! im pretty confident the static initializer is from some mystery tu because it only exists in revision 1 of the game, despite RPSysLoadScene being basically equivalent between the two revisions. also, there arent any symbols in wii fit u that suggest there could be extra data

[kiwi515]

Suggested change

	RP_SINGLETON_IMPL_EX(RPSysQueuedScene)
	RP_SINGLETON_IMPL_EX(RPSysQueuedScene);

[kiwi515]

Suggested change

	#include <RPSystem.h>
	#include <Pack/RPSystem.h>

[kiwi515]

could u copy paste the doc-comment from above the declaration pls

[kiwi515]

Suggested change

	inline s32 getSceneID() {
	s32 getSceneID() const {

[kiwi515]

these functions will be private by default without public: