Skip to content

split RPBowScene and attempt some TUs - #149

Open
Alex9303 wants to merge 2 commits into
doldecomp:masterfrom
Alex9303:Bowling
Open

split RPBowScene and attempt some TUs#149
Alex9303 wants to merge 2 commits into
doldecomp:masterfrom
Alex9303:Bowling

Conversation

@Alex9303

Copy link
Copy Markdown
Contributor

No description provided.

@decomp-dev

decomp-dev Bot commented Aug 30, 2026

Copy link
Copy Markdown

Report for RSPE01_01 (eb5969b - 238c3f0)

📈 Matched code: 34.11% (+0.15%, +5288 bytes)
📈 Matched data: 37.55% (+0.00%, +68 bytes)

✅ 45 new matches
Unit Item Bytes Before After
main/Pack/RPSports/RPBowScene/RPBowBackgroundNpcManager Bowling::RPBowBackgroundNpcManager::Render() +1008 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowBallReturnRack Bowling::RPBowBallReturnRack::SelectBallForNPC() +456 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowMotionBlur Bowling::RPBowMotionBlur::DrawBlur(void*) +432 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowMotionBlur Bowling::RPBowMotionBlur::UpdateBlurTransform(const nw4r::math::MTX34*, float) +404 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager Bowling::RPBowGlobalLaneManager::UpdateBallsMdl(Bowling::SceneObjectManager*) +304 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager Bowling::CheckBallLaneIntersection(float*, float) +292 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowBallReturnRack Bowling::RPBowBallReturnRack::ResetRackBallStates() +188 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowBallReturnRack Bowling::RPBowBallReturnRack::InitBallReturnRack(long) +168 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowNpcManager Bowling::RPBowNpcManager::Setup(Bowling::LaneContext*, Bowling::NpcContext*, Bowling::NpcContext*, Bowling::NpcContext*, int, Bowling::RPBowBallReturnRack*, void*) +164 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowManagerContext Bowling::RPBowManagerContext::Initialize() +152 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowBackgroundNpcManager Bowling::RPBowBackgroundNpcManager::InitializeConfig(int) +152 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager Bowling::RPBowGlobalLaneManager::UpdateBallsPhysics() +140 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager Bowling::RPBowGlobalLaneManager::ResetLanePinsAndAnimations() +124 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowNpcManager Bowling::RPBowNpcManager::ActivateNpcTurn() +124 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager Bowling::RPBowGlobalLaneManager::SetupBallManagerLaneObjects(void*, void*) +100 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowPinSetter Bowling::ResetPinSetterState(Bowling::LaneContext*, unsigned char) +96 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowManagerContext Bowling::RPBowManagerContext::SetNpcStateFlags(unsigned char) +92 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowManagerContext Bowling::RPBowNpcManager::~RPBowNpcManager() +88 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowManagerContext Bowling::RPBowManagerContext::DebugPrintStates() +88 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowActiveBall Bowling::RPBowActiveBall::ResetRenderState() +80 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager Bowling::RPBowGlobalLaneManager::InitializeBallManagerLanes() +76 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager Bowling::RPBowGlobalLaneManager::TickNpcLanes() +76 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowBackgroundNpcManager .bss +68 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager Bowling::RPBowGlobalLaneManager::SetLaneUnknownState(int) +60 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowBallReturnRack Bowling::RPBowBallReturnRack::SpawnBallOnRack(long) +40 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowTrajectoryGuide Bowling::RPBowTrajectoryGuide::Initialize() +40 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowTrajectoryGuide Bowling::RPBowTrajectoryGuide::Reset() +40 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowPinSetter Bowling::TriggerPinSetter(Bowling::LaneContext*, int) +36 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowPinSetter Bowling::IsPinSetterActive(Bowling::LaneContext*) +36 0.00% 100.00%
main/Pack/RPSports/RPBowScene/RPBowBallReturnRack Bowling::RPBowBallReturnRack::InitBallSlotResources(long, RPGrpModel*, RPGrpModel*, long) +32 0.00% 100.00%

...and 15 more new matches

📈 25 improvements in unmatched items
Unit Item Bytes Before After
main/Pack/RPSports/RPBowScene/RPBowBackgroundNpcManager Bowling::RPBowBackgroundNpcManager::UpdateMovement(nw4r::math::VEC3*, bool*) +1537 0.00% 96.55%
main/Pack/RPSports/RPBowScene/RPBowBallReturnRack Bowling::RPBowBallReturnRack::UpdateBallReturnRack(long) +966 0.00% 96.65%
main/Pack/RPSports/RPBowScene/RPBowActiveBall Bowling::RPBowActiveBall::RenderModelSet() +906 0.00% 97.64%
main/Pack/RPSports/RPBowScene/RPBowPinSetter Bowling::UpdatePinSetter(Bowling::LaneContext*) +803 0.00% 96.10%
main/Pack/RPSports/RPBowScene/RPBowTrajectoryGuide Bowling::RPBowTrajectoryGuide::Draw() +722 0.00% 95.02%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager Bowling::RPBowGlobalLaneManager::UpdateLaneItems(int, void*, Bowling::SomeUnkManager0*, bool) +493 0.00% 98.00%
main/Pack/RPSports/RPBowScene/RPBowManagerContext Bowling::RPBowManagerContext::UpdateNpcs() +439 0.00% 99.77%
main/Pack/RPSports/RPBowScene/RPBowBackgroundNpcManager Bowling::RPBowBackgroundNpcManager::Reset() +250 0.00% 99.52%
main/Pack/RPSports/RPBowScene/RPBowManagerContext Bowling::RPBowManagerContext::LinkNpcLanes(Bowling::RPBowGlobalLaneManager*, Bowling::SceneObjectManager*) +203 0.00% 99.61%
main/Pack/RPSports/RPBowScene/RPBowBackgroundNpcManager .sdata2 +91 0.00% 95.83%
main/Pack/RPSports/RPBowScene/RPBowMotionBlur Bowling::RPBowMotionBlur::~RPBowMotionBlur() +88 0.00% 95.65%
main/Pack/RPSports/RPBowScene/RPBowBackgroundNpcManager Bowling::RPBowBackgroundNpcManager::~RPBowBackgroundNpcManager() +88 0.00% 68.75%
main/Pack/RPSports/RPBowScene/RPBowTrajectoryGuide Bowling::RPBowTrajectoryGuide::~RPBowTrajectoryGuide() +88 0.00% 95.65%
main/Pack/RPSports/RPBowScene/RPBowBallReturnRack .sdata2 +74 0.00% 92.68%
main/Pack/RPSports/RPBowScene/RPBowTrajectoryGuide Bowling::UpdateControllerState(unsigned long*) +43 0.00% 71.87%
main/Pack/RPSports/RPBowScene/RPBowPinSetter .sdata2 +36 0.00% 90.00%
main/Pack/RPSports/RPBowScene/RPBowTrajectoryGuide .sdata2 +32 0.00% 80.00%
main/Pack/RPSports/RPBowScene/RPBowActiveBall .sdata2 +30 0.00% 94.12%
main/Pack/RPSports/RPBowScene/RPBowManagerContext .rodata +15 0.00% 8.42%
main/Pack/RPSports/RPBowScene/RPBowMotionBlur .sdata2 +14 0.00% 88.89%
main/Pack/RPSports/RPBowScene/RPBowManagerContext .sdata2 +12 0.00% 75.00%
main/Pack/RPSports/RPBowScene/RPBowGlobalLaneManager .sdata2 +6 0.00% 80.00%
main/Pack/RPSports/RPBowScene/RPBowNpcManager .sdata2 +1 0.00% 10.00%
main/Pack/RPSports/RPBowScene/RPBowBackgroundNpcManager Bowling::RPBowBackgroundNpcManager::fn_8034E96C() +1 0.00% 20.00%
main/Pack/RPSports/RPBowScene/RPBowBackgroundNpcManager Bowling::RPBowBackgroundNpcManager::fn_8034DD0C() +1 0.00% 20.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant