RPSysHomeMenuMgr WIP for real - #154
Merged
Merged
Conversation
added 15 commits
August 27, 2026 14:08
Report for RSPE01_01 (4c08445 - 0d67c24)📈 Matched code: 34.18% (+0.04%, +1292 bytes) ✅ 10 new matches
📈 6 improvements in unmatched items
|
kiwi515
requested changes
Sep 4, 2026
| ->GetFileFromArchive(staComArc, "/HomeMenu/homeBtnIcon.bti"); | ||
|
|
||
| switch (mProjectLocal->getLanguage()) { | ||
| case (RPSysProjectLocal::EArea_France): { |
Collaborator
There was a problem hiding this comment.
we just write the switch cases without parentheses:
case XYZ: {
// . . .
}
. . .| } | ||
| } | ||
| RPSysScene* sceneRP = RP_GET_INSTANCE(RPSysSceneMgr)->getCurrentSceneRP(); | ||
| //! This function is stubbed out in rev 1 |
Collaborator
There was a problem hiding this comment.
the pauseCallback implementation in RPSysScene is empty so that derived classes can override it. although i dont think anything in wii sports overrides that method
| private: | ||
| //! Sound handle | ||
| nw4r::snd::SoundHandle& mrHandle; // at 0x28 | ||
| nw4r::snd::SoundHandle& mrHandle; // at 0x24 |
Collaborator
There was a problem hiding this comment.
i think u brought these changes back by mistake :p
| bool setupArchive(const void* pBinary); | ||
|
|
||
| private: | ||
| static RPSndHomeMenuArcMgr* spInstance; |
Collaborator
There was a problem hiding this comment.
i dont think this is a singleton instance. it looks like RPSysHomeMenuMgr just owns this as a static member. could u make the instance a static member of RPSysHomeMenuMgr, and remove the instance() method here?
maybe something like static RPSndHomeMenuArcMgr* spHomeMenuArcMgr;
Contributor
Author
There was a problem hiding this comment.
Will do. I was getting that feeling, but I wasn't sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following description was from my original request:
Code is 61% matched, with several functions at 100%.
update()requires review as uncommenting the commented code causes the function to experience a 0% match (compared to 77%).clearMenu()is unfinished, whileDestroyInstance()may not actually exist.