Skip to content

M3DUtil/MActorAnm: wrap the MtxCalcTypeName comment to 80 columns - #155

Merged
Mrkol merged 1 commit into
doldecomp:mainfrom
KakarottoCake:m3dutil-format-80col
Aug 29, 2026
Merged

M3DUtil/MActorAnm: wrap the MtxCalcTypeName comment to 80 columns#155
Mrkol merged 1 commit into
doldecomp:mainfrom
KakarottoCake:m3dutil-format-80col

Conversation

@KakarottoCake

Copy link
Copy Markdown
Contributor

One comment block, rewrapped. No code, no wording changes.

The three lines above enum MActorMtxCalcType landed in c19ae4d at 82 and 81 columns
against the repo's ColumnLimit: 80, so check-format-and-tidy fails on the file.

This is currently failing every open pull request. The clang-format action walks the
whole tree rather than the diff, so any PR goes red as soon as it merges main -- for a
violation none of them introduced. I ran into it on #154 and confirmed it is not specific
to that branch, which is why this is split out here rather than left riding on it: the
other open PRs should not have to wait on mine to go green.

It is also the only one. After this reflow, clang-format --dry-run -Werror across all of
src/ and include/ reports zero failing files.

-// The names come from the MtxCalcTypeName table in M3DUtil/InfectiousStrings.hpp,
-// which survives in the ROM (read it in MarioDraw.cpp's .data): its four entries
-// are "MActorMtxCalcType_Basic", "_Softimage", "_MotionBlend" and "_User".
+// The names come from the MtxCalcTypeName table in
+// M3DUtil/InfectiousStrings.hpp, which survives in the ROM (read it in
+// MarioDraw.cpp's .data): its four entries are "MActorMtxCalcType_Basic",
+// "_Softimage", "_MotionBlend" and "_User".

The same commit is also on #154 so that branch could go green on its own. Once this
merges, the two are identical content and #154 will fast-forward past it cleanly -- but if
you would rather it exist in only one place, say so and I will drop it from #154.

The comment block above `enum MActorMtxCalcType` landed in c19ae4d at 82 and 81
columns, against the repo's `ColumnLimit: 80`, so `check-format-and-tidy` fails
on it.

This is not confined to one branch. The clang-format action walks the whole tree
rather than the diff, so every open pull request goes red the moment it merges
main, for a violation none of them introduced. I hit it on doldecomp#154 and confirmed it
is not specific to that branch.

It is also the only one: after this reflow, `clang-format --dry-run -Werror`
across all of `src/` and `include/` reports zero failing files.

Only the line breaks move. The wording is unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@decomp-dev

decomp-dev Bot commented Aug 29, 2026

Copy link
Copy Markdown

Report for GMSJ01 (3f6c413 - 71a41d2)

No changes

@Mrkol
Mrkol merged commit 825bcd1 into doldecomp:main Aug 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants