M3DUtil/MActorAnm: wrap the MtxCalcTypeName comment to 80 columns - #155
Merged
Conversation
The comment block above `enum MActorMtxCalcType` landed in c19ae4d at 82 and 81 columns, against the repo's `ColumnLimit: 80`, so `check-format-and-tidy` fails on it. This is not confined to one branch. The clang-format action walks the whole tree rather than the diff, so every open pull request goes red the moment it merges main, for a violation none of them introduced. I hit it on doldecomp#154 and confirmed it is not specific to that branch. It is also the only one: after this reflow, `clang-format --dry-run -Werror` across all of `src/` and `include/` reports zero failing files. Only the line breaks move. The wording is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One comment block, rewrapped. No code, no wording changes.
The three lines above
enum MActorMtxCalcTypelanded in c19ae4d at 82 and 81 columnsagainst the repo's
ColumnLimit: 80, socheck-format-and-tidyfails on the file.This is currently failing every open pull request. The clang-format action walks the
whole tree rather than the diff, so any PR goes red as soon as it merges
main-- for aviolation none of them introduced. I ran into it on #154 and confirmed it is not specific
to that branch, which is why this is split out here rather than left riding on it: the
other open PRs should not have to wait on mine to go green.
It is also the only one. After this reflow,
clang-format --dry-run -Werroracross all ofsrc/andinclude/reports zero failing files.The same commit is also on #154 so that branch could go green on its own. Once this
merges, the two are identical content and #154 will fast-forward past it cleanly -- but if
you would rather it exist in only one place, say so and I will drop it from #154.