Decompile Boss Pakkun - #157
Open
KakarottoCake wants to merge 25 commits into
Open
Conversation
Brings in JKernel and JAudio work through 97f5012. No overlap with the Boss Pakkun files; merge is clean.
Report for GMSJ01 (c0071c2 - 19f7581)📈 Matched code: 38.91% (+0.29%, +10272 bytes) ✅ 89 new matches
...and 59 more new matches 📈 44 improvements in unmatched items
...and 14 more improvements in unmatched items |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/Enemy/bosspakkun.cppwas empty on main. This fills it in, along withinclude/Enemy/BossPakkun.hpp.82 of 126 functions match. 293 of 296 data objects match;
.bssand.sdata2are exact and
.rodatais 7 bytes short. The unit stays NonMatching.The TU needs
M3DUtil/InfectiousStrings.hpp. Without it we were 224 bytes shortin
.rodataahead of the string table, which shifted every pool reference inTBossPakkunParams::TBossPakkunParamsandTBossPakkunManager::load. Both matchexactly once it is included.
Known gaps:
TNerveBPDie::execute(80.2%) is the last structural one. Retail repeatsmodBgm(0, 1)in both arms of a branch and the source factors it into a singlecall. I did not duplicate an identical call to gain the score.
ignoreWaterCheck(0x4 vs0xf0),
initJParticle(0x274 vs 0x280),vomitFinished(0x40 vs 0x3c).changeBckspells the previous-index transitions as separateifbranchesinstead of a
switchwith fall-through cases. Retail emits its own parametercall per branch, so the fall-through form does not reproduce it, but the
ifform does repeat one line three times. Happy to change it back if you would
rather have the
switch.