Skip to content

Workaround for RelaxedJS '--build-once' not working #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nbanyan wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Workaround for RelaxedJS '--build-once' not working #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f537673
Workaround for RelaxedJS '--build-once' not working
Jul 8, 2024
c0d78cb
Fix to fix_image_alignment failing to detect an image's style attribute.
Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mkdocs_with_pdf/drivers/relaxedjs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,7 @@ def write_pdf(self, html_string: str, output: str):
self._logger.info(f" {log}")
if proc.poll() is not None:
break
# workaround for '--build-once' not working
if log.find("Now idle and waiting for file changes") > -1:
proc.kill()
break
7 changes: 6 additions & 1 deletion mkdocs_with_pdf/utils/image_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ def fix_image_alignment(soup: PageElement, logger: Logger = None):
if img.has_attr('class') and 'twemoji' in img['class']:
continue

styles = _parse_style(getattr(img, 'style', ''))
if not (img.has_attr('align')
or img.has_attr('width')
or img.has_attr('height')):
continue

styles = _parse_style(img.get('style', ''))

logger.debug(f' | {img}')
if img.has_attr('align'):
Expand Down