Delegate to Turbo's view-transitions if enabled#20
Open
pascallaliberte wants to merge 1 commit intodomchristie:mainfrom
Open
Delegate to Turbo's view-transitions if enabled#20pascallaliberte wants to merge 1 commit intodomchristie:mainfrom
pascallaliberte wants to merge 1 commit intodomchristie:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19
Makes Turn automatically detect when
<meta name="view-transition" content="same-origin">is present and disables its own view transitions, letting Turbo handle them natively. This solves the redirect abort issue while preserving Turn's CSS animation capabilities.Detecting if the page has the
view-transitionsame-originmeta tagWith this PR, Turn auto-detects the native view-transition meta tag and delegates to Turbo when present. This works per-page (like
data-turn="false"), giving us control over which pages use Turn's view transitions vs Turbo's native handling.This works because:
ViewTransitionernaturally spans the entire navigation, including redirect follow-upsreset()call on redirect follow-up has nothing to abort -NullTurn.abort()is a no-op