Skip to content

Issue-130: Remove Task.Result access in HandleCancellation #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doomchild merged 1 commit into from
May 22, 2026
Merged

Issue-130: Remove Task.Result access in HandleCancellation #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions src/TaskExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,11 @@ public static partial class TaskExtensions
private static Exception PotentiallyUnwindException(Exception exception) => exception is AggregateException aggregateException
? aggregateException.InnerException ?? exception
: exception;

private static Exception HandleCancellation<T>(this Task<T> task)
{
try
{
T result = task.Result;

return new Exception("Expected canceled task");
}
catch (Exception exception)
{
return PotentiallyUnwindException(exception);
}
}

private static Exception HandleCancellation<T>(Task<T> task) =>
task.IsCanceled
? new TaskCanceledException()
: PotentiallyUnwindException(task.Exception ?? new Exception("Expected canceled task"));

/// <summary>
/// Monadic 'alt'.
Expand Down
Loading