filter out shared from yaml anchor output#239
filter out shared from yaml anchor output#239lucasyarid wants to merge 2 commits intodorny:masterfrom
Conversation
43087fb to
5ab3a8d
Compare
5ab3a8d to
a87ec7a
Compare
|
If I understand correctly, I think it's a bit weird for this logic to be based on the magic keyword "shared", but should rather be based on whether the yaml entry has an In other words it should be possible to have two (or more) different share-able anchored entries that don't trigger a build themselves but can be included as part of other entries. |
Agreed, but struggling to find how can I export this data from js-yaml. |
|
I'm not sure either (unfortunately don't have time to dig in). At work we have a pnpm workspace / monorepo and one of the subprojects is called "shared"; even though this wouldn't bite us in our current setup, it's easy to imagine getting bitten by this magic keyword if building a file filter to determine when to run "shared" CI jobs. |
|
@machty doesn't seem possible in js-yaml so we are a bit stuck here. I'll park this PR awaiting any suggestions but gonna have to eventually close it as I agree filtering just for |
fixes #131
This PR fixes the github actions
changesoutput when using the proposedsharedYAML anchor.There are unit tests for it but please do propose the correct standards.