[main] Update dependencies from dotnet/arcade, dotnet/arcade-services, dotnet/dnceng#16752
[main] Update dependencies from dotnet/arcade, dotnet/arcade-services, dotnet/dnceng#16752dotnet-maestro[bot] wants to merge 6 commits intomainfrom
Conversation
…422.1 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 11.0.0-beta.26211.1 -> To Version 11.0.0-beta.26222.1
|
cc @agocke & @Youssef1313 |
|
I saw this in arcarde-validation yesterday. The agent decided to fix it like: dotnet/arcade-validation@0dd07f0 Let me know if this is not the right fix here. |
|
The problem here is likely introduced by #16734 and #16754 sounds like the right fix. However, I have few doubts about #16734:
|
While v2 and v3 were both being co-released, the source was the same (it comes from a Git submodule that was shared with both projects). The only assertion at that time that was in v3 that would not "work" in v2 were the dynamic skips, since that requires engine cooperation. (Calling We previously "enabled" I'm not aware of anything else that would behave incorrectly if you used the v3 assertions with v2.
They would definitely break without some intervention, since both would define If the intention is to support v2, then using the v2 assertion library is the correct answer. Arbitrarily pulling the v3 assertion library really isn't a reusable strategy. It's fine for an end consumer who knows what they're doing, but definitely not something you'd want to propagate. Your consumers would need to know to bring in
Yes, they're definitely quite different. |
…424.2 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 11.0.0-beta.26211.1 -> To Version 11.0.0-beta.26224.2
…425.1 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 11.0.0-beta.26211.1 -> To Version 11.0.0-beta.26225.1
…ild 20260422.1 On relative base path root Microsoft.DotNet.DarcLib , Microsoft.DotNet.ProductConstructionService.Client From Version 1.1.0-beta.26214.2 -> To Version 1.1.0-beta.26222.1
…423.1 On relative base path root Microsoft.DncEng.SecretManager From Version 1.1.0-beta.26216.2 -> To Version 1.1.0-beta.26223.1
|
Thanks @bradwilson for sharing your expertise. @Youssef1313 / @agocke please prioritize unblocking this PR. We need to get it in for some future work in arcade. |
|
I personally would lean towards reverting #16734 for now, and discuss it to consider a balanced way to move forward. I would need to understand who are the current consumers of AOT assertions? Is it solely runtime? Are these projects that need AOT assertions on xunit.v3 already? If all AOT consumers we care about are xunit.v3, then my suggestion would be:
|
Yes, from what I know that's just dotnet/runtime. Andy introduced that forked project for AOT tests there. |
|
This is currently blocking the 10.0.8 build from publishing (need the update here for channel publishing) |
…427.3 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 11.0.0-beta.26211.1 -> To Version 11.0.0-beta.26227.3
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
From https://github.com/dotnet/arcade-services
From https://github.com/dotnet/dnceng