BuildGrammar wrapup for C# v8 - #1823
Open
Nigel-Ecma wants to merge 1 commit into
Open
Nigel-Ecma wants to merge 1 commit into
Nigel-Ecma wants to merge 1 commit into
Conversation
- Update tarball to v2.5.0
Nigel-Ecma
added
the
meeting: discuss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After looking I don’t think any of the remaining v8 issues/PRs will change the grammar so it should be safe to do this now, in the sense it shouldn’t need to be redone. However just in case I have not marked this as addressing issue 1805 and a grammar comparison can be run between the final v8 commit and the one tagged BuildGrammar-Baseline-260918.
This PR only changes files inside the tarball, if all tests pass it is good to go. The (hopefully) final v8 tarball will then be propagated into v9 when Bill next triggers his gnomes.