[release/9.0] Avoid C4319 build warnings in libunwind #122179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run runtime-libraries stress-ssl |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MihaZupan
requested review from
a team,
AaronRobinsonMSFT and
janvorli
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports a fix from upstream libunwind to address C4319 build warnings on Windows that were blocking HTTP & SSL stress runs. The warning occurs with MSVC when performing bitwise complement operations on unsigned long literals followed by masking.
- Changed the
UNW_ALIGNmacro to use explicitsize_tcasts instead of unsigned long literals - Updated libunwind version tracking to document the applied upstream PR
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/external/libunwind/include/libunwind_i.h | Modified UNW_ALIGN macro to use size_t casts for both operands, eliminating C4319 warnings on MSVC |
| src/native/external/libunwind-version.txt | Added reference to upstream PR #931 that provides this fix |
AaronRobinsonMSFT
added
the
Servicing-consider
AaronRobinsonMSFT
approved these changes
Dec 8, 2025
steveisok
added
Servicing-approved
steveisok
merged commit c1afd3e
into
dotnet:release/9.0-staging
171 of 179 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include libunwind/libunwind#931 in the build of the libunwind dependency.
Fixes runtime build errors on
1es-windows-2022-openthat are blocking HTTP & SSL stress runs.Customer Impact
Our internal HTTP and SSL stress tests are failing to build on the 8.0 branch.
An update of MSVC in the
1es-windows-2022-openimage brought updated analyzer rules that now fail the build of dotnet/runtime on Windows.This change adds
(size_t)casts in the libunwind dependency, which resolves the new errors.Regression
Infra update.
Testing
Regular CI is still passing + CI stress runs for HTTP and SSL now build and work again.
Risk
Low.
This is a one-line targeted fix that only adds casts.