Skip to content

Blazor Toolkit open source component configuration skill file included. - #1088

Open
Indhumathy-Loganathan wants to merge 75 commits into
dotnet:mainfrom
Indhumathy-Loganathan:main
Open

Blazor Toolkit open source component configuration skill file included.#1088
Indhumathy-Loganathan wants to merge 75 commits into
dotnet:mainfrom
Indhumathy-Loganathan:main

Conversation

@Indhumathy-Loganathan

@Indhumathy-Loganathan Indhumathy-Loganathan commented Aug 28, 2026

Copy link
Copy Markdown

Summary

Introduces the initial dotnet-blazor-toolkit plugin and the syncfusion-blazor-toolkit-install skill so AI agents can correctly install and configure the open-source Syncfusion Blazor Toolkit (Syncfusion.Blazor.Toolkit). The skill covers package identity, AddSyncfusionBlazorToolkit() registration, _Imports.razor namespaces, Fluent theme CSS, interactive render modes, and split Blazor Web App setup, with progressive-disclosure references for package identity, themes/hosts, render modes, split registration, and troubleshooting. The plugin is also registered in the skills marketplace so agents can discover it alongside existing Blazor skills.

Key Changes

  • Added the dotnet-blazor-toolkit plugin (plugin.json, .claude-plugin/plugin.json, .codex-plugin/plugin.json) pointing at ./skills/.
  • Registered dotnet-blazor-toolkit in .github/plugin/marketplace.json with an install/configure-focused description.
  • Added syncfusion-blazor-toolkit-install/SKILL.md with core rules, don’ts, a host/topology decision table, and minimal setup steps (package, Program.cs, imports, CSS, render modes).
  • Added install skill references:
    • references/package-identity.md — Toolkit vs commercial Syncfusion.Blazor* packages; no license key for Toolkit.
    • references/theme-and-host-files.md — Fluent CSS path and correct host file per app type.
    • references/render-modes.md — when interactive render modes are required.
    • references/split-webapp-registration.md — Server/Client registration for split Web Apps.
    • references/troubleshooting.md — common failure symptoms and fixes.
  • Scoped the skill to install/configure only; explicitly excludes commercial packages, license keys, Hybrid/MAUI, and per-component API guidance.

Validation

  • Verified plugin layout and skill paths match repository plugin conventions.
  • Confirmed YAML frontmatter (name, description, license, compatibility, metadata) and that the skill name matches the directory.
  • Reviewed progressive disclosure: lean SKILL.md plus one-level references/.
  • Checked USE FOR / DO NOT USE FOR wording to avoid conflict with commercial Syncfusion and core Blazor skills.
  • Validated Markdown links from SKILL.md to reference files and marketplace entry rendering.
  • Manually reviewed guidance for package ID, service registration, theme path, and render-mode accuracy against Toolkit setup patterns.

@AbhitejJohn

Copy link
Copy Markdown
Collaborator

@Indhumathy-Loganathan : Thank you for your contribution. Would you mind adding evals for the skills you've proposed based on the guidance here: https://github.com/dotnet/skills/blob/main/CONTRIBUTING.md#testing-and-validation? Without evals it's hard for us to assess the usefulness of skills.

Address PR review feedback: fix grader regexes (DateTime?, Theme, OpensOn), tighten Disabled and Label graders, enforce fully-qualified ChartSeriesType, correct output-not-contains to output-not-matches, add async void guards, tighten namespace checks, and shorten stimulus names. Aligns the commit message with the PR title.
Copilot AI lite review requested due to automatic review settings September 2, 2026 07:43
@Indhumathy-Loganathan

Copy link
Copy Markdown
Author

@Indhumathy-Loganathan please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree company="Syncfusion"

@Indhumathy-Loganathan

Copy link
Copy Markdown
Author

@Indhumathy-Loganathan : Thank you for your contribution. Would you mind adding evals for the skills you've proposed based on the guidance here: https://github.com/dotnet/skills/blob/main/CONTRIBUTING.md#testing-and-validation? Without evals it's hard for us to assess the usefulness of skills.

@AbhitejJohn , We have included the evals as suggested. Please check.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

There are eval/doc issues that are internally inconsistent or overly broad (causing false failures or misleading guidance) and should be corrected before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR introduces the initial Syncfusion Blazor Toolkit skill pack (skills + reference docs) and adds Vally eval coverage to validate the new skills’ expected outputs and guidance.

Changes:

  • Added new Syncfusion Blazor Toolkit skills (Popups router + Dialog, Notifications/Spinner, Inputs, Calendars, Buttons) with supporting reference documentation.
  • Added a new Charts reference documentation set to guide correct Toolkit usage patterns (enums, events, axes, styling, accessibility).
  • Added Vally eval specs under tests/dotnet-blazor-toolkit/ to validate correct component selection and key anti-pattern avoidance.
File summaries
File Description
tests/dotnet-blazor-toolkit/syncfusion-blazor-toolkit-popups/eval.yaml New eval coverage for dialog-vs-tooltip component choice.
tests/dotnet-blazor-toolkit/syncfusion-blazor-toolkit-notifications/eval.yaml New eval coverage for SfSpinner binding, accessibility label, and async render timing.
tests/dotnet-blazor-toolkit/syncfusion-blazor-toolkit-inputs/eval.yaml New eval coverage for Toolkit input components (binding + validation patterns).
tests/dotnet-blazor-toolkit/syncfusion-blazor-toolkit-charts/eval.yaml New eval coverage for Toolkit charts setup, enums, theming, and package naming.
tests/dotnet-blazor-toolkit/syncfusion-blazor-toolkit-calendars/eval.yaml New eval coverage for calendar/date/time pickers (TValue, UTC, binding patterns).
tests/dotnet-blazor-toolkit/syncfusion-blazor-toolkit-buttons/eval.yaml New eval coverage for Toolkit button patterns (async handlers, accessibility, anti-patterns).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-popups/SKILL.md Popups router skill defining decision matrix and routing to sub-skills.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-popups/router/dialog-vs-tooltip-decision-matrix.md Supporting decision-matrix reference for dialog vs tooltip usage.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-popups/dialog/SKILL.md Dialog sub-skill guidance, patterns, and anti-pattern workflows.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-popups/dialog/references/dialog-properties.md Dialog API reference (properties/events/methods).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-notifications/SKILL.md Spinner-focused notifications/loading skill guidance.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-notifications/references/spinner-template.md Spinner templating + customization reference.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-notifications/references/spinner-overlay.md Overlay composition patterns for spinners (page/region/modal).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-notifications/references/accessibility-best-practices.md Accessibility guidance for spinner usage.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-inputs/SKILL.md Inputs skill guidance (binding, validation, SSR constraints).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-inputs/references/getting-started-inputs.md Inputs “getting started” reference and examples.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-charts/references/interactive-features.md Charts interactivity reference (tooltip/crosshair/zoom/selection).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-charts/references/events.md Charts event wiring reference (<ChartEvents> surface).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-charts/references/data-handling.md Charts data-source guidance (lists, managers, live updates).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-charts/references/chart-types-specialized.md Specialized chart types reference (stacked/scatter/bubble/etc.).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-charts/references/axes-and-scales.md Axes/value types, ranges, striplines, and multi-axis patterns.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-charts/references/appearance-styling.md Charts styling/themes/palettes guidance.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-charts/references/advanced-features.md Advanced chart patterns (panes, trendlines, editing, RTL).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-charts/references/accessibility-internationalization.md Charts accessibility + i18n/RTL reference.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-calendars/SKILL.md Calendars skill guidance (TValue selection, UTC, min/max).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-calendars/references/getting-started.md Calendars getting-started reference.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-calendars/references/features.md Calendars features overview reference.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-calendars/references/events-binding.md Calendars events/binding/validation reference.
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-calendars/references/critical-gotchas.md Calendars critical gotchas reference (key pitfalls).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-buttons/SKILL.md Buttons skill guidance (async click patterns, anti-patterns).
plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-buttons/references/getting-started.md Buttons getting-started reference.
Review details

Suppressed comments (2)

plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-calendars/references/critical-gotchas.md:38

  • The example marks TValue="TimeOnly?" as a binding error, which contradicts the rest of this PR (including the SfTimePicker eval rubric). Update the snippet so agents don’t learn the wrong API surface.
    plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-calendars/references/critical-gotchas.md:191
  • The "When in doubt" guidance still says to avoid TimeOnly?, which conflicts with the rest of this PR’s calendar guidance. Align this summary with the corrected SfTimePicker support statement.
  • Files reviewed: 42/62 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings September 2, 2026 08:04
@Indhumathy-Loganathan

Indhumathy-Loganathan commented Sep 2, 2026

Copy link
Copy Markdown
Author

Corrections included.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The added skill documentation contains a few concrete correctness issues (contradictory guidance and inaccurate enum compilation wording) that could mislead agents and/or cause eval failures.

Review details

Suppressed comments (3)

Previously missed (3) — in code that hasn't changed since the last review.

plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-charts/references/accessibility-internationalization.md:89

  • This note says using a non-existent Theme.* enum value "compiles to silence". Since Theme is an enum, invalid members won’t compile; updating the wording will avoid spreading incorrect guidance.
    plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-charts/references/appearance-styling.md:131
  • This note says using a non-existent Theme.* enum value "compiles to silence". Since Theme is an enum, invalid members won’t compile; updating the wording will avoid spreading incorrect guidance.
    plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-notifications/SKILL.md:40
  • The guidance for Label + <Template> is internally inconsistent: this section says "Never both", but references/spinner-template.md later shows using Label together with a <Template> that is aria-hidden. Consider rewording to forbid only duplicate visible text, while still allowing Label for screen readers alongside an aria-hidden visual template.
  • Files reviewed: 42/62 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 2, 2026 11:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new eval contains a grader that will incorrectly fail valid answers by forbidding the phrase “license key” even when stating “no license key required.”

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 12/12 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread tests/dotnet-blazor-toolkit/syncfusion-blazor-toolkit-install/eval.yaml Outdated
Copilot AI review requested due to automatic review settings September 8, 2026 11:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The skill documentation contains a misleading “Blazor Server only” label for a .NET 8 Blazor Web App configuration section that should be clarified to avoid incorrect setup guidance.

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

plugins/dotnet-blazor-toolkit/skills/syncfusion-blazor-toolkit-install/SKILL.md:76

  • The section labeled "For Blazor Server only" uses the .NET 8+ Blazor Web App hosting model (AddRazorComponents + MapRazorComponents + render modes), not the legacy Blazor Server template (which typically uses _Host.cshtml and AddServerSideBlazor). This label is likely to mislead users who are actually on a Blazor Server template and can cause them to apply the wrong setup guidance.
  • Files reviewed: 12/12 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 8, 2026 11:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The new capability eval includes a rubric requirement that isn’t enforced by graders, reducing the evaluation’s ability to catch incorrect WASM host-file guidance.

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

tests/dotnet-blazor-toolkit/syncfusion-blazor-toolkit-install/eval.yaml:61

  • The WebAssembly installation stimulus rubric says to avoid suggesting App.razor as the WASM host file, but the graders don’t currently assert this. As written, an answer could mention both index.html and App.razor and still pass the automated checks, weakening the evaluation.
  • Files reviewed: 12/12 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 8, 2026 12:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings September 8, 2026 13:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Indhumathy-Loganathan Indhumathy-Loganathan changed the title Blazor Toolkit open source component related skill files were included. Blazor Toolkit open source component configuration skill file included. Sep 8, 2026
@AbhitejJohn
AbhitejJohn requested review from danroth27 and javiercn and removed request for webreidi September 8, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants