Remove duplicate Skill Value sample column - #1148
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3f54e78b-35cc-4a23-923e-fae37fb232d1
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new test mutates global state without robust cleanup and should be adjusted to avoid leaking globals and to fail with clearer assertions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
eng/dashboard/skill-value.test.js — This test overwrites globalThis.document/window/fetch but never restores the previous values, which… |
|
eng/dashboard/skill-value.test.js — wrap.innerHTML.match(...)[1] will throw a TypeError (instead of a clear assertion failure) if the… |
What changed in this PR
This PR updates the Skill Value dashboard table to remove a duplicated sample-count (“n”) column by using a single shared paired-observation count for both token and time deltas, and adds a regression test to lock in the new 7-column structure.
Changes:
- Remove the duplicate “n” column so token/time deltas share one paired-sample count.
- Update group/detail row column counts (
<td>blanks,colspan) to align with the new 7-column table. - Add a Node-based regression test validating the table header structure and
colspan.
| File | Description |
|---|---|
| eng/dashboard/skill-value.js | Removes duplicate sample-count column and realigns group/detail rows to 7 columns. |
| eng/dashboard/skill-value.test.js | Adds regression coverage for the Skill Value table header/colspan structure. |
Suppressed comments (1)
eng/dashboard/skill-value.test.js:63
- After restoring globals at setup time, also restore them at the end of the test so subsequent tests start from a clean environment (ideally this would be in a finally block).
});
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
👋 @AbhitejJohn — this PR has 2 unresolved review thread(s). When you're ready, please address the feedback and push an update; the triage bot will pick up the next state automatically. (Add the |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3f54e78b-35cc-4a23-923e-fae37fb232d1
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The column removal is consistently applied across header/body/group/drill-down rows and is backed by a focused regression test that asserts the intended 7-column structure.
Review tier: Lite
Findings: None
Issues resolved since last review (2)
| Severity | Finding |
|---|---|
eng/dashboard/skill-value.test.js — wrap.innerHTML.match(...)[1] will throw a TypeError (instead of a clear assertion failure) if the… View resolved comment |
|
eng/dashboard/skill-value.test.js — This test overwrites globalThis.document/window/fetch but never restores the previous values, which… View resolved comment |
|
✅ Evaluation passed for |


Summary
Before
Two identical N columns appear after the token and time deltas.
After
One shared N column reports the paired observation count used by both deltas.
Validation
node --test eng\dashboard\*.test.jsnode --check eng\dashboard\skill-value.jsnode --check eng\dashboard\skill-value.test.jsgit diff --check