Skip to content

solana-cli: shreds withdraw supports stale seats and --funds-only#347

Merged
karl-dz merged 3 commits intomainfrom
ms/withdraw-funds-only
Apr 14, 2026
Merged

solana-cli: shreds withdraw supports stale seats and --funds-only#347
karl-dz merged 3 commits intomainfrom
ms/withdraw-funds-only

Conversation

@martinsander00
Copy link
Copy Markdown
Contributor

@martinsander00 martinsander00 commented Apr 14, 2026 •
edited
Loading

Summary

  • Previously shreds withdraw required the seat to have active service, leaving users with stale seats unable to recover USDC from their payment escrow
  • The CLI now auto-detects stale seats and skips RequestInstantSeatWithdrawal, closing only the payment escrow to return funds
  • Adds --funds-only flag to explicitly skip the instant withdrawal request even when the seat is active

Lines of Code

Section Added Removed
SDKs +25 -10

@bgm-malbeclabs
Copy link
Copy Markdown
Collaborator

bgm-malbeclabs commented Apr 14, 2026

logic looks sound but can we add a test?

@martinsander00
Copy link
Copy Markdown
Contributor Author

martinsander00 commented Apr 14, 2026

logic looks sound but can we add a test?

yessir, working on it

karl-dz
karl-dz reviewed Apr 14, 2026
View reviewed changes
Comment thread crates/solana-cli/src/command/shreds/withdraw.rs Outdated
@martinsander00
Copy link
Copy Markdown
Contributor Author

martinsander00 commented Apr 14, 2026 •
edited
Loading

logic looks sound but can we add a test?

will add e2e in shreds repo

@karl-dz karl-dz merged commit 10800a7 into main Apr 14, 2026
5 checks passed
@karl-dz karl-dz deleted the ms/withdraw-funds-only branch April 14, 2026 18:07
@martinsander00 martinsander00 mentioned this pull request Apr 16, 2026
Merged
karl-dz pushed a commit that referenced this pull request Apr 16, 2026
@martinsander00
solana-cli: uptick crate to v0.5.3 (#348)
eadb3be 
## Summary of Changes
Uptick `doublezero-solana-cli` crate to v0.5.3.

Includes:
- `shreds list`: fall back to showing all seats when no default keypair
is found (#346)
- `shreds withdraw`: allow withdrawing funds from stale seats and add
`--funds-only` flag (#347)

## Testing Verification
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karl-dz karl-dz karl-dz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martinsander00 @bgm-malbeclabs @karl-dz