Migrate units/states/tasks/tasks.coffee from CoffeeScript to Angular by Sujay-Deakin · Pull Request #1235 · doubtfire-lms/doubtfire-web

Sujay-Deakin · 2026-05-24T07:53:10Z

Description

Migrates units/states/tasks/tasks.coffee from CoffeeScript/AngularJS to TypeScript/Angular as part of the ongoing Angular migration effort.

Changes

Created tasks.component.ts with UnitsTasksStateComponent replacing UnitsTasksStateCtrl
Created tasks.component.html with <ui-view> as the router outlet
Created tasks.component.scss (no custom styles needed)
Registered UnitsTasksStateComponent in doubtfire-angular.module.ts
Downgraded component in doubtfire-angularjs.module.ts for hybrid compatibility
Routing now handled entirely by Angular; UnitsTasksStateCtrl controller removed
Removed old import 'build/src/app/units/states/tasks/tasks.js' from doubtfire-angularjs.module.ts
Deleted tasks.coffee

Bug Fixes Applied During Migration

Null-safe parsing of taskKey from URL params
Null guard added to setTaskKeyFromUrlParams; service only called when taskKeyString is truthy, matching original behaviour
transitionService.onStart scoped to units/tasks.** to avoid firing on unrelated state transitions
Cleaner taskKey assignment using optional chaining

Testing

Component registers correctly in the Angular module
Downgraded directive available to AngularJS hybrid app
taskData initialises with correct default values
taskKey syncs correctly from URL params on load
Inbox and task explorer load correctly; no blocking console errors

Feat/assess in portfolio

…ions-job refactor: queue submission downloads to sidekiq

feat: init lti integration

…edback deadline

…eadline-warning refactor: require confirmation when setting project plan after the fe…

…on-rebase-onto-origin-8.0.x Migration grade icon rebase onto origin 8.0.x

* chore: migrate/unit-staff-editor - delete old Coffeescript file - delete old template - remove reference to old Coffeescript file - link new component - downgrade new component * chore: migrate/unit-staff-editor - port `unit-staff-editor-component` to Typescript from Coffeescript - port `unit-staff-editor` template to Angular template syntax w/ Angular Material - adjust parent component `Inputs` and attribute bindings * Update README.md * Update README.md --------- Co-authored-by: Boink <40929320+b0ink@users.noreply.github.com>

* fix: revert staff role on error * fix: ensure full search for unit role * chore: fix casing * refactor: use mat table for staff editor * chore: remove unused variables * fix: null check * refactor: use icon button * chore: remove unit staff editor coffeescript file * chore: add back staff editor tooltips

…pm_and_yarn/immutable-4.3.8 build(deps): bump immutable from 4.3.6 to 4.3.8

…m_and_yarn/rxjs-7.8.2 build(deps): bump rxjs from 7.4.0 to 7.8.2

…pm_and_yarn/node-forge-1.3.2 build(deps-dev): bump node-forge from 1.3.1 to 1.3.2

…m_and_yarn/axios-1.12.2 build(deps-dev): bump axios from 1.7.2 to 1.12.2

Bumps [@commitlint/cli](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/cli) from 16.3.0 to 20.1.0. - [Release notes](https://github.com/conventional-changelog/commitlint/releases) - [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/cli/CHANGELOG.md) - [Commits](https://github.com/conventional-changelog/commitlint/commits/v20.1.0/@commitlint/cli) --- updated-dependencies: - dependency-name: "@commitlint/cli" dependency-version: 20.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

…pm_and_yarn/commitlint/cli-20.1.0 build(deps-dev): bump @commitlint/cli from 16.3.0 to 20.1.0

Bumps [lottie-web](https://github.com/airbnb/lottie-web) from 5.12.2 to 5.13.0. - [Changelog](https://github.com/airbnb/lottie-web/blob/master/CHANGELOG.md) - [Commits](airbnb/lottie-web@v5.12.2...v5.13.0) --- updated-dependencies: - dependency-name: lottie-web dependency-version: 5.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [rollup](https://github.com/rollup/rollup) from 4.18.0 to 4.59.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.18.0...v4.59.0) --- updated-dependencies: - dependency-name: rollup dependency-version: 4.59.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

…m_and_yarn/lottie-web-5.13.0 build(deps): bump lottie-web from 5.12.2 to 5.13.0

Bumps [angular-mocks](https://github.com/angular/angular.js) from 1.5.11 to 1.8.3. - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.5.11...v1.8.3) --- updated-dependencies: - dependency-name: angular-mocks dependency-version: 1.8.3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/config-conventional) from 17.8.1 to 20.5.0. - [Release notes](https://github.com/conventional-changelog/commitlint/releases) - [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/config-conventional/CHANGELOG.md) - [Commits](https://github.com/conventional-changelog/commitlint/commits/v20.5.0/@commitlint/config-conventional) --- updated-dependencies: - dependency-name: "@commitlint/config-conventional" dependency-version: 20.5.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@types/jasmine](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jasmine) from 3.9.1 to 6.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jasmine) --- updated-dependencies: - dependency-name: "@types/jasmine" dependency-version: 6.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [@ctrl/ngx-emoji-mart](https://github.com/scttcper/ngx-emoji-mart) from 9.2.0 to 9.3.0. - [Release notes](https://github.com/scttcper/ngx-emoji-mart/releases) - [Commits](scttcper/ngx-emoji-mart@v9.2.0...v9.3.0) --- updated-dependencies: - dependency-name: "@ctrl/ngx-emoji-mart" dependency-version: 9.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…pm_and_yarn/ctrl/ngx-emoji-mart-9.3.0 build(deps): bump @ctrl/ngx-emoji-mart from 9.2.0 to 9.3.0

…pm_and_yarn/commitlint/config-conventional-20.5.0 build(deps-dev): bump @commitlint/config-conventional from 17.8.1 to 20.5.0

…pm_and_yarn/angular-mocks-1.8.3 build(deps): bump angular-mocks from 1.5.11 to 1.8.3

…pm_and_yarn/types/jasmine-6.0.0 build(deps-dev): bump @types/jasmine from 3.9.1 to 6.0.0

…pm_and_yarn/rollup-4.59.0 build(deps-dev): bump rollup from 4.18.0 to 4.59.0

…s and remove tasks.coffee

…sks component

…ansition scope

…ice compatibility

b0ink and others added 30 commits September 11, 2025 12:03

chore: include definition name in automated message

712a96b

chore: improve wording

c229f83

chore: add tooltips for submission type

b5dc3db

Merge pull request doubtfire-lms#963 from b0ink/feat/assess-in-portfolio

e9e489c

Feat/assess in portfolio

refactor: queue submission downloads to sidekiq

8232772

chore(release): 10.0.0-40

4ab0ab4

chore: reword prerequisite requirements

d88b7fa

Merge pull request doubtfire-lms#994 from b0ink/feat/download-submiss…

a6a8c3f

…ions-job refactor: queue submission downloads to sidekiq

chore(release): 10.0.0-41

91231dc

Merge branch '10.0.x' into feat/lti-web

dcc1529

chore: alert correct error

93304e6

chore: set lti port to 3001

f99fe72

refactor: replace apiUrl with hostUrl

54a2e69

chore: temp remove constants

a2ae46e

chore: restore and rename api constants

63ff1fd

Merge pull request doubtfire-lms#972 from b0ink/feat/lti-web

88865be

feat: init lti integration

chore(release): 10.0.0-42

8d82cd1

fix: remove /api from host url

5889edc

chore(release): 10.0.0-43

5a5e940

chore: use host url constant

189790a

refactor: require confirmation when setting project plan after the fe…

2cb57ee

…edback deadline

Merge pull request doubtfire-lms#996 from b0ink/feat/after-feedback-d…

489f440

…eadline-warning refactor: require confirmation when setting project plan after the fe…

chore(release): 10.0.0-44

058a721

Merge pull request doubtfire-lms#898 from Shounaks/migration-grade-ic…

c07757c

…on-rebase-onto-origin-8.0.x Migration grade icon rebase onto origin 8.0.x

refactor: check for a valid submission response

f6db02e

fix: check for valid unit

bfae1ad

feat: add observer only ui

bfbcee9

chore(release): 10.0.0-45

75feec9

b0ink and others added 30 commits March 23, 2026 13:40

Merge pull request doubtfire-lms#1102 from doubtfire-lms/dependabot/n…

be4574a

…pm_and_yarn/immutable-4.3.8 build(deps): bump immutable from 4.3.6 to 4.3.8

chore: update package-lock

ab03681

Merge pull request doubtfire-lms#989 from doubtfire-lms/dependabot/np…

9c6faba

…m_and_yarn/rxjs-7.8.2 build(deps): bump rxjs from 7.4.0 to 7.8.2

Merge pull request doubtfire-lms#1054 from doubtfire-lms/dependabot/n…

fc8a5f3

…pm_and_yarn/node-forge-1.3.2 build(deps-dev): bump node-forge from 1.3.1 to 1.3.2

Merge pull request doubtfire-lms#998 from doubtfire-lms/dependabot/np…

2714533

…m_and_yarn/axios-1.12.2 build(deps-dev): bump axios from 1.7.2 to 1.12.2

fix: only render if submission date is valid

04986a0

Merge pull request doubtfire-lms#1012 from doubtfire-lms/dependabot/n…

7f78acb

…pm_and_yarn/commitlint/cli-20.1.0 build(deps-dev): bump @commitlint/cli from 16.3.0 to 20.1.0

Merge pull request doubtfire-lms#993 from doubtfire-lms/dependabot/np…

90af025

…m_and_yarn/lottie-web-5.13.0 build(deps): bump lottie-web from 5.12.2 to 5.13.0

chore: update package-lock

cb06e15

Merge pull request doubtfire-lms#1131 from doubtfire-lms/dependabot/n…

c244457

…pm_and_yarn/ctrl/ngx-emoji-mart-9.3.0 build(deps): bump @ctrl/ngx-emoji-mart from 9.2.0 to 9.3.0

Merge pull request doubtfire-lms#1129 from doubtfire-lms/dependabot/n…

cbb9cc6

…pm_and_yarn/commitlint/config-conventional-20.5.0 build(deps-dev): bump @commitlint/config-conventional from 17.8.1 to 20.5.0

Merge pull request doubtfire-lms#1128 from doubtfire-lms/dependabot/n…

e38625b

…pm_and_yarn/angular-mocks-1.8.3 build(deps): bump angular-mocks from 1.5.11 to 1.8.3

Merge pull request doubtfire-lms#1130 from doubtfire-lms/dependabot/n…

730dcf2

…pm_and_yarn/types/jasmine-6.0.0 build(deps-dev): bump @types/jasmine from 3.9.1 to 6.0.0

Merge pull request doubtfire-lms#1094 from doubtfire-lms/dependabot/n…

23d54ae

…pm_and_yarn/rollup-4.59.0 build(deps-dev): bump rollup from 4.18.0 to 4.59.0

chore: update package-lock

2fefab2

chore(release): 10.0.1-22

c57c1c3

feat: create initial files for migration of units/states/tasks

257dd9b

feat: wire UnitsTasksStateComponent into Angular and AngularJS module…

0b73f0d

…s and remove tasks.coffee

fix: resolve module registration and correct TaskService import in ta…

34c2550

…sks component

fix: restore units/tasks state config and controller for hybrid routing

24eb2a1

refactor: address PR review feedback - fix routing, null guard and tr…

d2178c0

…ansition scope

refactor: address PR review feedback

fc035c6

fix: correct deregisterTransition type to Function for transitionServ…

009455d

…ice compatibility

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate units/states/tasks/tasks.coffee from CoffeeScript to Angular#1235

Migrate units/states/tasks/tasks.coffee from CoffeeScript to Angular#1235
Sujay-Deakin wants to merge 885 commits into
doubtfire-lms:developmentfrom
Sujay-Deakin:migrate/units-states-tasks-coffee

Sujay-Deakin commented May 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Sujay-Deakin commented May 24, 2026

Description

Changes

Bug Fixes Applied During Migration

Testing

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants