Conversation
…ble functionality - Deleted outdated power table files: power_table.ptab and power_table_incomplete.ptab. - Introduced new test file test_active_ride_table.cpp to validate ride log processing and power table generation. - Added test file test_power_table_csv.cpp to ensure correct saving and loading of power table data.
- Consolidated test cases in `test_power_table_csv.cpp` to focus on active ride CSV round-trip validation. - Updated `test_pt_lookup_resistance.cpp` to enhance cadence boundary checks and active ride forward lookup tests. - Streamlined `test_pt_lookup_watts.cpp` by removing redundant output and focusing on active ride reverse lookup validation. - Removed unnecessary file output in `test_unity.cpp` and organized test execution for better readability. - Added checks for monotonicity in lookup functions and ensured proper handling of edge cases in power table lookups.
Improve robustness and add a debug serial hook. Changes: replace byte-conversion macros with well-typed static_cast versions (include/BLE_Common.h); update root CA cert and timestamp (include/cert.h); enable SERIAL_CUSTOM_CHARACTERISTIC in debug build (platformio.ini) and add sdkconfig.S3debug; harden BLE custom characteristic parsing with required-length checks, safe integer assembly, bounds fix, and use setTarget for watts (src/BLE_Custom_Characteristic.cpp); add a newline-delimited serial command interface to invoke the custom characteristic for debugging (src/Main.cpp).
- stream browser firmware uploads through the ESP-IDF OTA API - avoid Arduino Update's 4 KiB heap allocation - remove automatic boot-time firmware installation - retain boot-time web filesystem refresh and missing-file repair - deprecate the automatic-update setting while preserving compatibility - regenerate classic and S3 settings assets
- Implement independent initialization of FastAccelStepper for safe operation without TMC UART. - Improve filesystem upload process with detailed error handling and remounting logic. - Ensure stepper-related functions check for initialization status to prevent runtime errors.
- Updated cert_updater.py to clarify its usage and removed direct execution in PlatformIO builds. - Added refreshBLEAdvertisementIp() function to BLE_Server for IP address updates in advertisements. - Modified syncWebServerFiles() in HTTP_Server to improve filesystem repair logic and error handling. - Enhanced DirConManager to check for active clients before broadcasting notifications. - Refactored startWifi() to streamline network service management and improve connection handling. - Improved error logging and handling across various components for better debugging and reliability.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework power table functionality, enhance BLE and logging features